Closed Bug 1516000 Opened 5 years ago Closed 5 years ago

Remove script_timeout from AWSY callers

Categories

(Remote Protocol :: Marionette, enhancement)

Product:
Remote Protocol
Component:
Marionette
Version:
65 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: kats, Unassigned)

References

Details

Bug 1510929 removed the script_timeout argument to execute_async_script but it missed callsites in AWSY code. Specifically https://searchfox.org/mozilla-central/rev/413dd3a1fab3446749f3690d93ee17e3196f8c37/testing/awsy/awsy/awsy_test_case.py#215 and friends.

This is causing AWSY breakage with patches from bug 1515521 although I'm not sure why it's happening on m-c right now.
Argh... looks like bug 1510929 was backed out for exactly this reason. And the patches from bug 1515521 are now causing different AWSY failures, and I never noticed that the failures where different. *sigh*
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
Sorry about that.  I wasn’t aware AWSY used the Marionette client.

As erahm noted in https://bugzilla.mozilla.org/show_bug.cgi?id=1510929#c7,
we can pull the removal of the scriptTimeout parameter to
WebDriver:ExecuteScript and :ExecuteAsyncScript into the client and
reset the timeout if the script_timeout kwarg has been given.

This seems less invasive than my original change, but with the
downside that we can’t remove the kwarg.  We intend to deprecate
the Marionette client altogether at some point (when we have a
better alternative, don’t worry!) so at the moment I don’t care
particularly about API cleanliness of this client.
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.