Closed Bug 1516016 Opened 5 years ago Closed 5 years ago

Prefs: show a focus ring on categories when tabbed to them

Categories

(Thunderbird :: Theme, enhancement)

Product:
Thunderbird
Component:
Theme
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 66.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

1516016-focus-ring.patch v2
3.84 KB, patch
darktrojan
: review+
Details | Diff | Splinter Review 
Like on the FX prefs, let the categories get a focus ring when the focus is on them through keyboard navigating.
Attached patch 1516016-focus-ring.patch (obsolete) — — Splinter Review 
I also added a focus ring around the tabs. Unlike the categories the focus ring stays after they are accessed through keyboard.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9033007 - Flags: review?(geoff)
After playing with this for a little bit, I think you need to respond to the up/down/left/right keys as well, otherwise it's good.
Is this better? Or does a more elegant version exist?
Attachment #9033007 - Attachment is obsolete: true
Attachment #9033007 - Flags: review?(geoff)
Attachment #9033032 - Flags: review?(geoff)
Comment on attachment 9033032 [details] [diff] [review]
1516016-focus-ring.patch v2

You could've done [KeyEvent.DOM_VK_TAB, KeyEvent.DOM_VK_UP…].includes(event.keyCode), but this looks nice, keep it.

Thanks.
Attachment #9033032 - Flags: review?(geoff) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/033ab4ab1fa42dd52f00031fbe3149362478fd22
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 66.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: