Closed
Bug 1516075
Opened 5 years ago
Closed 5 years ago
Port bug 1497995: Changed parameters of nsDocShellLoadState - nsMessenger.cpp:592:47: error: no matching constructor for initialization of 'nsDocShellLoadState'
Categories
(MailNews Core :: General, task)
MailNews Core
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 66.0
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
Details
Attachments
(1 file, 1 obsolete file)
|
8.67 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
Busted with nsMessenger.cpp:592:47: error: no matching constructor for initialization of 'nsDocShellLoadState'
|
Assignee | |
Updated•5 years ago
|
Version: 17 → Trunk
|
|
Assignee | |
Comment 1•5 years ago
|
||
This seems to compile. I'll look whether we can now lose the loadState->SetURI(url); calls since the URL is already passed in at object creation time.
|
|
Assignee | |
Comment 2•5 years ago
|
||
I was on the wrong boat, it's this: Bug 1497995 - Make nsDocShellLoadState take nsURI as a constructor argument And yes, all the SetURI() calls are removed, see example here: https://hg.mozilla.org/mozilla-central/rev/63e0af38669e#l1.141
Summary: Port bug 1478742: Changed parameters of nsDocShellLoadState - nsMessenger.cpp:592:47: error: no matching constructor for initialization of 'nsDocShellLoadState' → Port bug 1497995: Changed parameters of nsDocShellLoadState - nsMessenger.cpp:592:47: error: no matching constructor for initialization of 'nsDocShellLoadState'
|
|
Assignee | |
Comment 3•5 years ago
|
||
Attachment #9033065 -
Attachment is obsolete: true
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/c707d32abbd6 Port bug 1497995: Changed arguments of nsDocShellLoadState CTOR. rs=bustage-fix
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•5 years ago
|
||
Comment on attachment 9033068 [details] [diff] [review] 1516075-nsDocShellLoadState.patch (v2) Let's see who gets here first ;-)
Attachment #9033068 -
Flags: review?(mkmelin+mozilla)
Attachment #9033068 -
Flags: review?(geoff)
Attachment #9033068 -
Flags: review?(acelists)
|
|
Assignee | |
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 66.0
|
||
Comment 6•5 years ago
|
||
Comment on attachment 9033068 [details] [diff] [review] 1516075-nsDocShellLoadState.patch (v2) Review of attachment 9033068 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, r=mkmelin
Attachment #9033068 -
Flags: review?(mkmelin+mozilla)
Attachment #9033068 -
Flags: review?(geoff)
Attachment #9033068 -
Flags: review?(acelists)
Attachment #9033068 -
Flags: review+
|
||
Updated•5 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•