Port bug 1497995: Changed parameters of nsDocShellLoadState - nsMessenger.cpp:592:47: error: no matching constructor for initialization of 'nsDocShellLoadState'

RESOLVED FIXED in Thunderbird 66.0

Status

enhancement
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: jorgk, Assigned: jorgk)

Tracking

Trunk
Thunderbird 66.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

5 months ago
Busted with
nsMessenger.cpp:592:47: error: no matching constructor for initialization of 'nsDocShellLoadState'
Assignee

Updated

5 months ago
Version: 17 → Trunk
Assignee

Comment 1

5 months ago
This seems to compile. I'll look whether we can now lose the
  loadState->SetURI(url);
calls since the URL is already passed in at object creation time.
Assignee

Comment 2

5 months ago
I was on the wrong boat, it's this:
Bug 1497995 - Make nsDocShellLoadState take nsURI as a constructor argument

And yes, all the SetURI() calls are removed, see example here:
https://hg.mozilla.org/mozilla-central/rev/63e0af38669e#l1.141
Summary: Port bug 1478742: Changed parameters of nsDocShellLoadState - nsMessenger.cpp:592:47: error: no matching constructor for initialization of 'nsDocShellLoadState' → Port bug 1497995: Changed parameters of nsDocShellLoadState - nsMessenger.cpp:592:47: error: no matching constructor for initialization of 'nsDocShellLoadState'
Assignee

Comment 3

5 months ago
Attachment #9033065 - Attachment is obsolete: true

Comment 4

5 months ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/c707d32abbd6
Port bug 1497995: Changed arguments of nsDocShellLoadState CTOR. rs=bustage-fix
Status: NEW → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
Assignee

Comment 5

5 months ago
Comment on attachment 9033068 [details] [diff] [review]
1516075-nsDocShellLoadState.patch (v2)

Let's see who gets here first ;-)
Attachment #9033068 - Flags: review?(mkmelin+mozilla)
Attachment #9033068 - Flags: review?(geoff)
Attachment #9033068 - Flags: review?(acelists)
Assignee

Updated

5 months ago
Target Milestone: --- → Thunderbird 66.0
Comment on attachment 9033068 [details] [diff] [review]
1516075-nsDocShellLoadState.patch (v2)

Review of attachment 9033068 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #9033068 - Flags: review?(mkmelin+mozilla)
Attachment #9033068 - Flags: review?(geoff)
Attachment #9033068 - Flags: review?(acelists)
Attachment #9033068 - Flags: review+
You need to log in before you can comment on or make changes to this bug.