1516128 - --with-system-jpeg=PREFIX doesn't respect PREFIX

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jan Beich]

On FreeBSD packages are installed under /usr/local by default. As --with-system-jpeg doesn't rely on "pkg-config libjpeg" the user have to append =/usr/local which would be converted to CFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib. Unfortunately, after moz.configure conversion jpeg version check happens before *FLAGS are set.

$ pkg info -x jpeg
jpeg-turbo-2.0.0

$ echo 'ac_add_options --with-system-jpeg=${LOCALBASE-/usr/local}' >>.mozconfig
$ ./mach build
[...]
checking for jpeg_destroy_compress... yes
checking for sufficient jpeg library version...
DEBUG: <truncated - see config.log for full output>
DEBUG: | #include <sys/types.h>
DEBUG: | #include <jpeglib.h>
DEBUG: | int
DEBUG: | main(void)
DEBUG: | {
DEBUG: |
DEBUG: | #if JPEG_LIB_VERSION < 62
DEBUG: | #error Insufficient JPEG library version
DEBUG: | #endif
DEBUG: |
DEBUG: |   ;
DEBUG: |   return 0;
DEBUG: | }
DEBUG: Executing: `/usr/bin/clang -std=gnu99 -c /tmp/conftest.EQbIow.c`
DEBUG: The command returned non-zero exit status 1.
DEBUG: Its error output was:
DEBUG: | /tmp/conftest.EQbIow.c:3:10: fatal error: 'jpeglib.h' file not found
DEBUG: | #include <jpeglib.h>
DEBUG: |          ^~~~~~~~~~~
DEBUG: | 1 error generated.
ERROR: Insufficient JPEG library version for --with-system-jpeg (62 required)
*** Fix above errors and then restart with\
               "./mach build"
gmake: *** [client.mk:115: configure] Error 1

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1516128 - Add missing compile flags in jpeg compile tests after bug 1515852.

Comment 2

[Jan Beich]

Comment on attachment 9033105 [details]
Bug 1516128 - Add missing compile flags in jpeg compile tests after bug 1515852.

I confirm, this fixes --with-system-jpeg build on FreeBSD.

Comment 3

[Kim Moir [:kmoir] ET]

Triaging, assigning to jbeich since they attached patches.

Comment 4

[Kim Moir [:kmoir] ET]

oops, previous comment should have said glandium

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b63d0e63975e
Add missing compile flags in jpeg compile tests after bug 1515852. r=froydnj

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/b63d0e63975e