Closed
Bug 1516135
Opened 5 years ago
Closed 5 years ago
[wpt-sync] Sync PR 14649 - Produce a valid report when no tests are affected
Categories
(Testing :: web-platform-tests, enhancement, P4)
Testing
web-platform-tests
Tracking
(firefox67 fixed)
RESOLVED
FIXED
mozilla67
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 14649 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/14649 Details from upstream follow. Robert Ma <robertma@chromium.org> wrote: > Produce a valid report when no tests are affected > > This is done in a roundabout way: > 1. Instead of early exiting, `wpt run` now continues to call wptrunner > when no tests are affected to make sure we have suite_start and > suite_end lifecycle events. > 2. However, wptrunner would then by default run all tests, so a new flag > is added to wptrunner to only run the given list of tests and do not > fail when no tests run. > > Fixes #14471 . > > P.S. I haven't looked into the tests yet (I'd expect some might break; or you reviewers would like to see new tests). Please first let me know if the general approach looks good. Thanks!
Assignee | ||
Comment 1•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=69089d26baf6d3cce4e9c643c0e65d0bcc5ded7b
Assignee | ||
Comment 2•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c20d509f5a73b412079699ebc9f7f62d6c82978
Assignee | ||
Comment 3•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=1016feffe4d2904b8b92fe44ee0951112ea378cb
Assignee | ||
Comment 4•5 years ago
|
||
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/984da02c45f8 [wpt PR 14649] - Produce a valid report when no tests are affected, a=testonly
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/7e0785c0e88e [wpt PR 14649] - Produce a valid report when no tests are affected, a=testonly
Comment 7•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•