Closed Bug 1516135 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 14649 - Produce a valid report when no tests are affected

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 14649 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14649
Details from upstream follow.

Robert Ma <robertma@chromium.org> wrote:
>  Produce a valid report when no tests are affected
>  
>  This is done in a roundabout way:
>  1. Instead of early exiting, `wpt run` now continues to call wptrunner
>     when no tests are affected to make sure we have suite_start and
>     suite_end lifecycle events.
>  2. However, wptrunner would then by default run all tests, so a new flag
>     is added to wptrunner to only run the given list of tests and do not
>     fail when no tests run.
>  
>  Fixes #14471 .
>  
>  P.S. I haven't looked into the tests yet (I'd expect some might break; or you reviewers would like to see new tests). Please first let me know if the general approach looks good. Thanks!
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/984da02c45f8
[wpt PR 14649] - Produce a valid report when no tests are affected, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e0785c0e88e
[wpt PR 14649] - Produce a valid report when no tests are affected, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.