Closed Bug 1516188 Opened 5 years ago Closed 5 years ago

Alignment of "Bugs Filed" section in profile page is not same as of rest of rows below it.

Categories

(bugzilla.mozilla.org :: Extensions, defect)

Production
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: spiro, Assigned: spiro)

References

()

Details

Attachments

(2 files, 3 obsolete files)

Attached image bug.png
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0

Steps to reproduce:

I opened my Bugzilla profile page.


Actual results:

Alignment of "Bugs Filed" section is not same as of rest of rows below it (But profiles of other people are displayed correctly). I


Expected results:

All rows should have been aligned same.
Assignee: general → nobody
Component: Bugzilla-General → Extensions: UserProfile
Product: Bugzilla → bugzilla.mozilla.org
QA Contact: default-qa
Version: unspecified → Production
I think it's the position of image that is causing the 2 rows getting shifted. While inspecting about the issue, I found 2 strange things that could be contributing to the bug.

1) My profile does not have section of "Permissions". So it is causing image to sink down below horizontal border.

2) When looking into source code of page, rowspan of 'gravatar container' is set to 8 while in other profiles it is 6.
https://github.com/mozilla-bteam/bmo/blob/1670cadacee38d3ba0c2341717c5e02568986973/extensions/UserProfile/template/en/default/pages/user_profile.html.tmpl#L50

the rowspan value seems to be wrong, both for `user.id == target.id` case and other case.
also, there's no row which is added on that condition.

Here's the list of rows and their conditions, in the affected range:
  * "Created" :                     target.can('creation_ts')
  * "Permissions" :                 target.in_group("canconfirm")
  * "Edit Profile & Preferences" :  user.id

and there are 3 more rows that is added unconditionally ("User", "Last activity", " "), before the separator for either "Review Queue" or "User Statistics".

so, the minimum value of rowspan should be 3 and the number should be incremented on each condition, up to 6.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee: nobody → sharma.divyansh.501
Status: NEW → ASSIGNED
Attached file GitHub Pull Request (obsolete) —
Tooru,

Please look at this and suggest changes. Thanks.
Flags: needinfo?(arai.unmht)
answered in IRC
clearing ni? for now.
Flags: needinfo?(arai.unmht)
Attached patch GitHub Pull Request (obsolete) — Splinter Review
Attachment #9033340 - Attachment is obsolete: true
Flags: needinfo?(arai.unmht)
Comment on attachment 9033394 [details] [diff] [review]
GitHub Pull Request

Review of attachment 9033394 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/UserProfile/template/en/default/pages/user_profile.html.tmpl
@@ +47,3 @@
>  
>  <tr>
>    [% offset = user.id == target.id ? 2 : 0 %]

the number of row doesn't change with this condition.
please remove this variable.

@@ +48,5 @@
>  <tr>
>    [% offset = user.id == target.id ? 2 : 0 %]
> +  [% permissions_offset = target.in_group("canconfirm") == 1 ? 1 : 0 %]
> +  [% creation_offset = target.can('creation_ts') == 1 ? 1 : 0 %]
> +   <td rowspan="[% user.id ? 4 + offset + permissions_offset + creation_offset : 3 + offset + permissions_offset + creation_offset %]" id="gravatar-container">

it would be nice to make one more variable for `user.id` condition (the "edit profile" row), so that you don't have to repeat the almost same thing in then-clause and else-clause.
Attachment #9033394 - Attachment is patch: true
Attachment #9033394 - Attachment mime type: text/x-github-pull-request → text/plain
Flags: needinfo?(arai.unmht)
Attached file GitHub Pull Request (obsolete) —
Attachment #9033394 - Attachment is obsolete: true
Flags: needinfo?(arai.unmht)
Attached file GitHub Pull Request
Attachment #9033402 - Attachment is obsolete: true
Flags: needinfo?(arai.unmht)
Will be deployed next week
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Component: Extensions: UserProfile → Extensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: