Closed
Bug 1516194
Opened 5 years ago
Closed 5 years ago
Move nsSMILNullType into the mozilla namespace
Categories
(Core :: SVG, enhancement)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: longsonr, Assigned: longsonr)
Details
Attachments
(2 files)
|
15.71 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
|
2.14 KB,
patch
|
longsonr
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•5 years ago
|
||
Assignee: nobody → longsonr
Attachment #9033135 -
Flags: review?(dholbert)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9033135 [details] [diff] [review] patch Review of attachment 9033135 [details] [diff] [review]: ----------------------------------------------------------------- r=me (Looks like this will need minor unbitrotting for the SMILLFloatType changes in bug 1516175.)
Attachment #9033135 -
Flags: review?(dholbert) → review+
Pushed by longsonr@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3a5eb424e655 rename nsSMILNullType to SMILNullType and move it to the mozilla namespace r=dholbert
|
|
Assignee | |
Comment 4•5 years ago
|
||
Looks like some reformatting got missed from the initial patch.
Attachment #9033420 -
Flags: review?(dholbert)
|
|
Assignee | |
Comment 5•5 years ago
|
||
Comment on attachment 9033420 [details] [diff] [review] Part 2 - fix indentation has r+ in bug 1516521
Attachment #9033420 -
Flags: review?(dholbert) → review+
Pushed by longsonr@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/006f69326ccc fix identation in SMILNullType.cpp r=dholbert
|
|
||
Comment 7•5 years ago
|
||
Thanks!
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3a5eb424e655 https://hg.mozilla.org/mozilla-central/rev/006f69326ccc
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•