1516268 - tinymce not working properly in 64 version, in 63 works fine

Status: NEW

(Core :: Layout: Images, Video, and HTML Frames, defect, P2)

Description

[zitalman]

Attachment: ff_64_fail.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

Insert an image in tinymce v3 WYSIWYG tool


Actual results:

The image is inserted correctly, but I can choose it to resize it.


Expected results:

The image is clicked and the editor added a border to resize it.

In Firefox 63 version works fine

Comment 1

[Matthias Versen [:Matti]]

>Insert an image in tinymce v3 WYSIWYG tool
Please provide an URL or attach a testcase as file to this report.

The resize works for me using https://www.tiny.cloud/docs/demo/full-featured/ and Firefox64 and Firefox66 nightly on windows.

Comment 2

[Alice0775 White]

AFAIK, This behavior is as designed and introduced by Bug 1490641. 
And It is reproduced on TinyMCE V3. 
But, It seems to be already fixed on latest TinyMCE V4(https://www.tiny.cloud/docs/demo/full-featured/).

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Oddly, TinyMCE does not enable our resizers:
https://github.com/tinymce/tinymce/search?q=enableObjectResizing&unscoped_q=enableObjectResizing
I.e., they are using their own resizers.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

FYI: changing editor.resizing.enabled_by_default, editor.inline_table_editing.enabled_by_default and/or editor.positioning.enabled_by_default to true in about:config making the UI shown by default like 63 and earlier.

Comment 5

[zitalman]

We use a customized TinyMCE v3 version, and if we upgraded to v4 we need to port all our code, but thanks for the help.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to zitalman from comment #5)
> We use a customized TinyMCE v3 version, and if we upgraded to v4 we need to
> port all our code, but thanks for the help.

Does comment 4 "fix" on your apps? If so, you can fix this with adding the following execCommand()s at initialization.

document.execCommand("enableObjectResizing", false, true); // Only this may be fine.
document.execCommand("enableInlineTableEditing", false, true); // for <table> elements.
document.execCommand("enableAbsolutePositionEditing", false, true); // for position:absolute elements.

Comment 7

[zitalman]

It doesn't work

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to zitalman from comment #7)
> It doesn't work

Thanks, but sounds really odd... We need to find the fixing commit of TinyMCE v4.

Comment 9

[Daniel Bodea [:danibodea]]

I think there is an open issue on Tinymice side (on GitHub). Is this the same issue?
https://github.com/tinymce/tinymce/issues/4714
Or maybe this other one?
https://github.com/tinymce/tinymce/pull/4640

I can't see any other way to help as using the tool seems a bit complicated, but if a dev sais that it is necessary, I will do my best to learn to use the tool and reproduce the issue. NI? me if further testing is needed.

Furthermore, I will set this bug's component as (Core) Layout: Images, Videos and HTML Frames. If this is incorrect, please choose a more appropriate one.

Comment 10

[zitalman]

(In reply to Bodea Daniel [:danibodea] from comment #9)
> I think there is an open issue on Tinymice side (on GitHub). Is this the
> same issue?
> https://github.com/tinymce/tinymce/issues/4714
> Or maybe this other one?
> https://github.com/tinymce/tinymce/pull/4640
> 
> I can't see any other way to help as using the tool seems a bit complicated,
> but if a dev sais that it is necessary, I will do my best to learn to use
> the tool and reproduce the issue. NI? me if further testing is needed.
> 
> Furthermore, I will set this bug's component as (Core) Layout: Images,
> Videos and HTML Frames. If this is incorrect, please choose a more
> appropriate one.

Yes, It is, but we started porting the code to tinymce4

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Happy to take a patch in nightly 67, or potentially, in beta 66 for this.
Marking as fix-optional to remove it from weekly regression triage, since there is a priority assigned.

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Well, we need a URI of TinyMCE v3 instance to investigate whether we can include a hack like bug 1514940. However, nobody comments the examples here...

Comment 13

[zitalman]

tinymcev3.tar.gz
https://ufile.io/y1edv

Comment 14

[rino]

Well, we need a URI of TinyMCE v3 instance to investigate whether we can include a hack like bug 1514940. However, nobody comments the examples here...

How about:
http://fiddle.tinymce.com/zEgaab

Comment 15

[Neha Kochar [:neha]]

Bulk change for all regression bugs with status-firefox67 as 'fix-optional' to be marked 'affected' for status-firefox68.

Comment 16

[Kagami Rosylight [:saschanaz] (they/them)]

Do we want to do anything here? http://fiddle.tinymce.com/zEgaab from Comment 14 does reproduce this issue but the behavior is same on Chrome.

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.