1516276 - Intermittent toolkit/mozapps/update/tests/browser/browser_updatesCompletePatchApplyFailure.js | A promise chain failed to handle a rejection: request is null - stack: handleCriticalWriteFailure@

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: apavel [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=218680063&repo=autoland

https://queue.taskcluster.net/v1/task/chSBZfopQci6Pwgyi60VQQ/runs/0/artifacts/public/logs/live_backing.log

18:23:48     INFO - TEST-START | toolkit/mozapps/update/tests/browser/browser_updatesCompletePatchApplyFailure.js
18:23:48     INFO - GECKO(4276) | *** AUS:SVC UpdateManager:_writeUpdatesToXMLFile - no updates to write. removing file: C:\ProgramData\Mozilla\updates\FAB39FA56BE21F43\active-update.xml
18:23:48     INFO - GECKO(4276) | *** AUS:SVC UpdateManager:_loadXMLFileIntoArray - update xml file updates.xml exists but doesn't contain any updates
18:23:48     INFO - GECKO(4276) | *** AUS:SVC UpdateService.canCheckForUpdates - able to check for updates
18:23:48     INFO - GECKO(4276) | *** AUS:SVC isServiceInstalled - returning true
18:23:48     INFO - GECKO(4276) | *** AUS:SVC shouldUseService - returning true
18:23:48     INFO - GECKO(4276) | *** AUS:SVC getCanApplyUpdates - bypass the write checks because the Windows Maintenance Service can be used
18:23:48     INFO - GECKO(4276) | *** AUS:SVC readStatusFile - status: failed: 4, path: C:\ProgramData\Mozilla\updates\FAB39FA56BE21F43\updates\0\update.status
18:23:48     INFO - GECKO(4276) | *** AUS:SVC readStringFromFile - file doesn't exist: C:\ProgramData\Mozilla\updates\FAB39FA56BE21F43\updates\0\bt.result
18:23:48     INFO - GECKO(4276) | *** AUS:SVC readBinaryTransparencyResult - result: null, path: C:\ProgramData\Mozilla\updates\FAB39FA56BE21F43\updates\0\bt.result
18:23:48     INFO - GECKO(4276) | *** AUS:SVC handleFallbackToCompleteUpdate - install of complete or only one patch offered failed. Notifying observers. topic: update-error, status: unknown, update.patchCount: 1, oldType: complete
18:23:48     INFO - GECKO(4276) | *** AUS:SVC UpdateManager:_writeUpdatesToXMLFile - Exception: Win error 183 during operation rename on file C:\ProgramData\Mozilla\updates\FAB39FA56BE21F43\updates.xml (Cannot create a file when that file already exists.
18:23:48     INFO - GECKO(4276) | )
18:23:48     INFO - GECKO(4276) | *** AUS:SVC Unable to write to critical update file: updates.xml
18:23:48     INFO - GECKO(4276) | JavaScript error: jar:file:///Z:/task_1545673607/build/application/firefox/omni.ja!/components/nsUpdateService.js, line 1133: TypeError: request is null
18:23:48     INFO - GECKO(4276) | *** AUS:SVC UpdateManager:_writeUpdatesToXMLFile - no updates to write. removing file: C:\ProgramData\Mozilla\updates\FAB39FA56BE21F43\active-update.xml
18:23:48     INFO - GECKO(4276) | ++DOCSHELL 00B69C00 == 4 [pid = 3152] [id = {bb1f6d17-e474-411a-b33a-3ae05fc4d27e}]
18:23:48     INFO - GECKO(4276) | ++DOMWINDOW == 14 (07A6D300) [pid = 3152] [serial = 17] [outer = 00000000]
18:23:48     INFO - GECKO(4276) | ++DOMWINDOW == 15 (07AEA800) [pid = 3152] [serial = 18] [outer = 07A6D300]
18:23:48     INFO - GECKO(4276) | [Child 3152, Main Thread] WARNING: 'NS_FAILED(rv)', file z:/build/build/src/dom/base/nsContentUtils.cpp, line 8205
18:23:48     INFO - GECKO(4276) | [Parent 5328, Main Thread] WARNING: 'NS_FAILED(rv)', file z:/build/build/src/netwerk/url-classifier/UrlClassifierCommon.cpp, line 121
18:23:48     INFO - GECKO(4276) | ++DOMWINDOW == 16 (0ACA6800) [pid = 3152] [serial = 19] [outer = 07A6D300]
18:23:48     INFO - TEST-INFO | started process screenshot
18:23:48     INFO - TEST-INFO | screenshot: exit 0
18:23:48     INFO - Buffered messages logged at 18:23:48
18:23:48     INFO - Entering test bound setDefaults
18:23:48     INFO - Console message: AUS:SVC UpdateManager:_writeUpdatesToXMLFile - no updates to write. removing file: C:\ProgramData\Mozilla\updates\FAB39FA56BE21F43\active-update.xml
18:23:48     INFO - Leaving test bound setDefaults
18:23:48     INFO - Entering test bound testCompletePatchApplyFailure
18:23:48     INFO - Console message: AUS:SVC UpdateManager:_loadXMLFileIntoArray - update xml file updates.xml exists but doesn't contain any updates
18:23:48     INFO - Console message: AUS:SVC UpdateService.canCheckForUpdates - able to check for updates
18:23:48     INFO - Console message: AUS:SVC isServiceInstalled - returning true
18:23:48     INFO - Console message: AUS:SVC shouldUseService - returning true
18:23:48     INFO - Console message: AUS:SVC getCanApplyUpdates - bypass the write checks because the Windows Maintenance Service can be used
18:23:48     INFO - Console message: AUS:SVC readStatusFile - status: failed: 4, path: C:\ProgramData\Mozilla\updates\FAB39FA56BE21F43\updates\0\update.status
18:23:48     INFO - Console message: AUS:SVC readStringFromFile - file doesn't exist: C:\ProgramData\Mozilla\updates\FAB39FA56BE21F43\updates\0\bt.result
18:23:48     INFO - Console message: AUS:SVC readBinaryTransparencyResult - result: null, path: C:\ProgramData\Mozilla\updates\FAB39FA56BE21F43\updates\0\bt.result
18:23:48     INFO - Console message: AUS:SVC handleFallbackToCompleteUpdate - install of complete or only one patch offered failed. Notifying observers. topic: update-error, status: unknown, update.patchCount: 1, oldType: complete
18:23:48     INFO - Console message: AUS:SVC UpdateManager:_writeUpdatesToXMLFile - Exception: Win error 183 during operation rename on file C:\ProgramData\Mozilla\updates\FAB39FA56BE21F43\updates.xml (Cannot create a file when that file already exists.
18:23:48     INFO - )
18:23:48     INFO - Console message: AUS:SVC Unable to write to critical update file: updates.xml
18:23:48     INFO - Console message: [JavaScript Error: "TypeError: request is null" {file: "jar:file:///Z:/task_1545673607/build/application/firefox/omni.ja!/components/nsUpdateService.js" line: 1133}]
18:23:48     INFO - Console message: AUS:SVC UpdateManager:_writeUpdatesToXMLFile - no updates to write. removing file: C:\ProgramData\Mozilla\updates\FAB39FA56BE21F43\active-update.xml
18:23:48     INFO - TEST-PASS | toolkit/mozapps/update/tests/browser/browser_updatesCompletePatchApplyFailure.js | The right notification showed up. - 
18:23:48     INFO - TEST-PASS | toolkit/mozapps/update/tests/browser/browser_updatesCompletePatchApplyFailure.js | update-manual notification is showing - 
18:23:48     INFO - TEST-PASS | toolkit/mozapps/update/tests/browser/browser_updatesCompletePatchApplyFailure.js | What's new link points to the test_details URL - 
18:23:48     INFO - TEST-PASS | toolkit/mozapps/update/tests/browser/browser_updatesCompletePatchApplyFailure.js | What's new link is not hidden. - 
18:23:48     INFO - TEST-PASS | toolkit/mozapps/update/tests/browser/browser_updatesCompletePatchApplyFailure.js | Landed on manual update page. - 
18:23:48     INFO - Buffered messages finished
18:23:48     INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/browser/browser_updatesCompletePatchApplyFailure.js | A promise chain failed to handle a rejection: request is null - stack: handleCriticalWriteFailure@jar:file:///Z:/task_1545673607/build/application/firefox/omni.ja!/components/nsUpdateService.js:1133:9
18:23:48     INFO - handleCriticalWriteResult@jar:file:///Z:/task_1545673607/build/application/firefox/omni.ja!/components/nsUpdateService.js:1176:5
18:23:48     INFO - UM__saveUpdatesXML/<@jar:file:///Z:/task_1545673607/build/application/firefox/omni.ja!/components/nsUpdateService.js:2889:30
18:23:48     INFO - Rejection date: Mon Dec 24 2018 18:23:48 GMT+0000 (GMT) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 257
18:23:48     INFO - Stack trace:
18:23:48     INFO - resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:257
18:23:48     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1131
18:23:48     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
18:23:48     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:995
18:23:48     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:focusedOrLoaded/<:803
18:23:48     INFO - Leaving test bound testCompletePatchApplyFailure
18:23:48     INFO - GECKO(4276) | MEMORY STAT | vsize 795MB | vsizeMaxContiguous 723MB | residentFast 282MB | heapAllocated 105MB
18:23:48     INFO - TEST-OK | toolkit/mozapps/update/tests/browser/browser_updatesCompletePatchApplyFailure.js | took 626ms

Comment 1

[Intermittent Failures Robot]

1 failures in 1008 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 1

Platform breakdown:
* windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1516276&startday=2018-12-24&endday=2018-12-30&tree=all

Comment 2

[Robert Strong (they/them - no direct email)]

I hope to fix this in bug 1499004

Comment 3

[Robert Strong (they/them - no direct email)]

This should be fixed by the patch that landed in bug 1499004 so resolving as fixed.