1516283 - Zoom isn't restored after exiting fullscreen if browser.ui.zoom.force-user-scalable = true

Status: NEW

(Core :: Layout, defect, P3)

Description

[csheany]

User Agent: Mozilla/5.0 (Android 7.1.1; Tablet; rv:66.0) Gecko/66.0 Firefox/66.0

Steps to reproduce:

With browser.ui.zoom.force-user-scalable set to true

1. Open a page with video (e.g. YouTube)
2. Zoom in
3. Enter fullscreen
4. Exit fullscreen



Actual results:

The page is zoomed out.


Expected results:

The page should still be zoomed in.

Comment 1

[Stefan Deiac]

Hi and thanks for your report. 
I tried to reproduce your issue using Samsung Galaxy Tab S3(Android 8.0), Huawei P9 Lite(Android 6.0), OnePlus 5T (Android 8.1.0) and Motorola Nexus 6 (Android 7.1.1) on all branches (Nightly, Beta, Release) but I wasn't able. Can you make a video with your problem? Also if you have any additional information please let us know, thanks.

Comment 2

[csheany]

Edit: The description should have also said that can't be zoomed in otherwise.

It happens consistently and is the only differnce I can think of compared to Bug 1511137.

Comment 3

[Botond Ballo [:botond]]

I am unable to reproduce this either. After exiting fullscreen, the page is zoomed in to the same level as it was before fullscreen.

Which Nightly were you testing with?

Comment 4

[csheany]

Nightly 66.0a1 (2019-01-14)

Are you entering fullscreen before or after the video is playing?

Is the video auto rotated?

With media.videocontrols.lock-video-orientation it doesn't happen.

Comment 5

[Botond Ballo [:botond]]

(In reply to csheany from comment #4)

Nightly 66.0a1 (2019-01-14)

Ok, same.

Are you entering fullscreen before or after the video is playing?

I've tried both, no difference in behaviour.

Is the video auto rotated?

Yep.

One possible source of difference is screen size (phoen vs. tablet). Unfortunately, I have not been able to get my hands on a working Android tablet yet.

Comment 6

[csheany]

With YouTube or another site?

Comment 7

[Botond Ballo [:botond]]

I was testing with YouTube. (Mobile site, now that I think of it. Perhaps I should test with "Request desktop site"?)

Comment 8

[csheany]

Just confirming mobile, desktop isn't affected.

Comment 9

[csheany]

I thought orientation might have been factor but I can also reprdouce starting in landscape.

Comment 10

[csheany]

What do you experience with w3schools.com/html/html5_video.asp

Comment 11

[Botond Ballo [:botond]]

(In reply to csheany from comment #10)

What do you experience with w3schools.com/html/html5_video.asp

I can reproduce it on the desktop version of the site. Seems to be independent of browser.ui.zoom.force-user-scalable, which suggests it may a different issue from what you're seeing.

Comment 12

[Botond Ballo [:botond]]

The issue that I'm seeing is an interaction between code to update the zoom level when changing orientation, and code to update the zoom level when entering/exiting fullscreen. Possibly the code to update the zoom level when changing orientation should be suppressed for orientation changes triggered by fullscreen entry/exit.

Comment 13

[csheany]

That would support my findings in comment 4 but is contrary to comment 9.

Should the summary be changed accordingly?

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Botond is this also an issue with geckoview?

Comment 15

[Andreas Bovens [:abovens]]

Is this something we want to tackle together with our other viewport fixes? CC Sean.

Comment 16

[Botond Ballo [:botond]]

(In reply to Liz Henry (:lizzard) (use needinfo) from comment #14)

Botond is this also an issue with geckoview?

Yes, the issue is in code shared by Fennec and GeckoView.

(In reply to Andreas Bovens [:abovens] from comment #15)

Is this something we want to tackle together with our other viewport fixes?

FWIW, this is on my list of viewport-related issues to fix in the coming months, but given the low severity, it's not near the top of the list.

Comment 17

[Sean Voisen (:svoisen)]

I'll keep note of it as a lower-priority work item per comment 16.

Comment 18

[Chris Peterson [:cpeterson]]

This is most likely a layout bug, not a video bug.

Comment 19

[csheany]

Depending on Comment 9...

This may not be about zoom at all.

The summary should probably be edited differently.

I was going to leave it up to Botond.

Comment 20

[BugBot [:suhaib / :marco/ :calixte]]

The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.