Closed Bug 1516451 Opened 5 years ago Closed 5 years ago

Port Bug 1516266 Unify the "arrowscrollbox" and "arrowscrollbox-clicktoscroll" bindings

Categories

(Thunderbird :: General, task)

Product:
Thunderbird
Component:
General
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 66.0

People

(Reporter: jorgk-bmo, Assigned: Paenglab)

References

Details

Attachments

(1 file)

1516451-arrowscrollbox.patch
1.34 KB, patch
jorgk-bmo
: review+
Details | Diff | Splinter Review 
As per bug 1516266 comment #5:

should be a simple change on the TB side (changing the base binding from #arrowscrollbox-clicktoscroll to #arrowscrollbox).
Flags: needinfo?(arshdkhn1)
Patch to be ready when the m-c bug is merged.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9033356 - Flags: review?(jorgk)
Comment on attachment 9033356 [details] [diff] [review]
1516451-arrowscrollbox.patch

Hmm, short review. Have you tested it, I haven't.
Flags: needinfo?(arshdkhn1)
Attachment #9033356 - Flags: review?(jorgk) → review+
(In reply to Jorg K (GMT+1) (urgent reviews and bustage fix only, Dec 22nd to Jan 1st) from comment #2)
> Comment on attachment 9033356 [details] [diff] [review]
> 1516451-arrowscrollbox.patch
> 
> Hmm, short review. Have you tested it, I haven't.

No, but it is the same as https://hg.mozilla.org/integration/mozilla-inbound/rev/82be4a42a1d3#l1.12. Not sure how I could test it.
Tested it with a lot of tabs to make the arrows appear. Scrolling still works but with smaller steps (around a third of a tab per click to one tab before).
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/4b5dd8656307
Port Bug 1516266: Use extends="...arrowscrollbox" instead of "...arrowscrollbox-clicktoscroll" in tabmail.xml. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 66.0
Type: defect → task
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: