Port Bug 1516266 Unify the "arrowscrollbox" and "arrowscrollbox-clicktoscroll" bindings

RESOLVED FIXED in Thunderbird 66.0

Status

defect
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: jorgk, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 66.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Reporter

Description

5 months ago
As per bug 1516266 comment #5:

should be a simple change on the TB side (changing the base binding from #arrowscrollbox-clicktoscroll to #arrowscrollbox).
Flags: needinfo?(arshdkhn1)
Assignee

Comment 1

5 months ago
Patch to be ready when the m-c bug is merged.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9033356 - Flags: review?(jorgk)
Reporter

Comment 2

5 months ago
Comment on attachment 9033356 [details] [diff] [review]
1516451-arrowscrollbox.patch

Hmm, short review. Have you tested it, I haven't.
Flags: needinfo?(arshdkhn1)
Attachment #9033356 - Flags: review?(jorgk) → review+
Assignee

Comment 3

5 months ago
(In reply to Jorg K (GMT+1) (urgent reviews and bustage fix only, Dec 22nd to Jan 1st) from comment #2)
> Comment on attachment 9033356 [details] [diff] [review]
> 1516451-arrowscrollbox.patch
> 
> Hmm, short review. Have you tested it, I haven't.

No, but it is the same as https://hg.mozilla.org/integration/mozilla-inbound/rev/82be4a42a1d3#l1.12. Not sure how I could test it.
Assignee

Comment 4

5 months ago
Tested it with a lot of tabs to make the arrows appear. Scrolling still works but with smaller steps (around a third of a tab per click to one tab before).

Comment 5

5 months ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/4b5dd8656307
Port Bug 1516266: Use extends="...arrowscrollbox" instead of "...arrowscrollbox-clicktoscroll" in tabmail.xml. r=jorgk
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
Reporter

Updated

5 months ago
Target Milestone: --- → Thunderbird 66.0
You need to log in before you can comment on or make changes to this bug.