1516482 - Change the way to propagate user gesture activation flag in order to adapt the Fission model

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Alastor Wu [:alwu]]

In present e10s model, we traverse the document tree and set the documents' flag, which won't be available under the Fission model, because documents from different origins would be in the different process.

Therefore, we should travese the browsing context tree instead and have a mechanism to set all documents' flag across different processes.

Comment 1

[Alastor Wu [:alwu]]

Implemented in bug1470346, the propagation rule is to activate all documents within the tab no matter they're in same origin or not.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1516482 - part1 : save user gesture activation flag in top level browsing context

In order to adapt Fission model, we should traverse browsing context tree and do the flag propagation because
we might not be available to traverse all documents in same document tree within one process.

In addition, the propagation rule of user gesture activation is that if one document is activated by user gesture,
we would activate all the other documents which are in same document tree.

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1516482 - part2 : update user gesture activation flag across IPC.

When the docShell is not presented in current browsing context, that means the document is in other
content process. Therefore, we would notify chrome browsing context in order to find the corresponding
browser context which is in other process and set the document's flag.

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1516482 - part3 : reset user gesture activation flag when top level document changes.

As the user gesture activation flag is a flag which is used to reflect whether the corresponding
document of browsing context has been activated by user or not, we should reset the flag when the
top level window changes its document.

Comment 5

[Alastor Wu [:alwu]]

In order to finish all related works, we would need a sync engine to allow us sync info between different browsing contexts, that will be implemented in bug 1519151.

As we're lacking of such sync mechanism now, I would only implement sync the info between browsing contexts which are in child and parent process.

Comment 6

[Alastor Wu [:alwu]]

Try result looks good.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=66edd68341b869f4fe4e133dedeb4318832eebb7

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a59ebb819c2
part1 : save user gesture activation flag in top level browsing context r=nika
https://hg.mozilla.org/integration/autoland/rev/da7cefd6569a
part2 : update user gesture activation flag across IPC. r=nika
https://hg.mozilla.org/integration/autoland/rev/ea8b794f04d8
part3 : reset user gesture activation flag when top level document changes. r=nika

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/8a59ebb819c2
https://hg.mozilla.org/mozilla-central/rev/da7cefd6569a
https://hg.mozilla.org/mozilla-central/rev/ea8b794f04d8

Comment 9

[Chris Peterson [:cpeterson]]

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732