1516509 - "Send Later" on a message with only BCC recipients doesn't insert To: undisclosed-recipients: ; header

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Jorg K (CEST = GMT+2)]

STR:
New message, add BCC recipient, Ctrl+Shift+Enter.
Check message in Outbox. No To: undisclosed-recipients: ;

Works when message is sent straight away.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1516509-undisclosed-recipients.patch - WIP

This addes the undisclosed-recipients when the message is saved in the Outbox. However, it cannot be sent, I get:

There are non-ASCII characters in the local part of the recipient address . This is not yet supported. Please change this address and try again.

Note the space before the dot, so the %s replacement has actually not worked :-(

errorIllegalLocalPart=There are non-ASCII characters in the local part of the recipient address %s. This is not yet supported. Please change this address and try again.

Comment 2

[Jorg K (CEST = GMT+2)]

This is really messy. When I add undisclosed-recipients with the patch, sending fails here:
https://searchfox.org/comm-central/rev/03af5b2cc1c3d24641b60f7f72a4a7d533865a1f/mailnews/compose/src/nsSmtpProtocol.cpp#339

I only get one empty address :-( - Hence the replacement of % with an empty string. Without the patch, I get the BCC recipient. So something really twisted going on. So if some other code sees the To: it doesn't collect the BCC or some such :-(

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1516509-undisclosed-recipients.patch (v2)

OK, this fixes it. Note that there was a bug in StripOutGroupNames(). With the correction the debug shows:
=== send buf |undisclosed-recipients: ;,[e-mail]|
=== send buf | ,[e-mail]|

Without the correction it shows:
=== send buf |undisclosed-recipients: ;,[e-mail]|
=== send buf |u ,[e-mail]|

so the group isn't correctly stripped. "u" doesn't have an e-mail address, hence the error described in comment #1.

I left the debug in for the reviewers convenience.

This fix comes too late for my Christmas message which sadly went out without
To: undisclosed-recipients: ;
:-(

Comment 4

[:aceman]

Comment on attachment 9033439 [details] [diff] [review]
1516509-undisclosed-recipients.patch (v2)

Review of attachment 9033439 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, I have tested both Send and Send later with a Bcc recipient, and they work with this patch.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/152f35832bad
add undisclosed-recipients when queueing message. r=aceman DONTBUILD

Comment 6

[Jorg K (CEST = GMT+2)]

TB 60.5 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/af3c67223e0678b9d6ecc4b72ecad701c777f6f0

Comment 7

[Jorg K (CEST = GMT+2)]

TB 65 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/8432e7fd9626148b3787ccc429a28588079a21bf