1516529 - [remote-dbg-next] Network connections are not persisted across reloads

Status: VERIFIED FIXED

(DevTools :: about:debugging, defect, P1)

Description

[Julian Descottes [:jdescottes]]

STRs:
- start another Firefox with `--start-debugger-server 6080`
- back to test instance of Firefox
- enable network locations for about:debugging-new by setting devtools.aboutdebugging.network to true
- open about:debugging-new 
- add localhost:6080
- click on Connect
- reload 

ER: localhost:6080 should still be connected
AR: Connect button is displayed again

A fair share of the logic to refresh connections is USB-only at the moment.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1516529 - Restore connections for NetworkRuntimes;r=daisuke

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1516529 - Test that network runtime connections are also persisted;r=daisuke

Depends on D15409

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7593c6b7d1e
Restore connections for NetworkRuntimes;r=daisuke
https://hg.mozilla.org/integration/autoland/rev/e03824ca4e74
Test that network runtime connections are also persisted;r=daisuke

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b7593c6b7d1e
https://hg.mozilla.org/mozilla-central/rev/e03824ca4e74

Comment 5

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox Nightly 68.0a1, Firefox Dev Edition 67.0b4 and on Firefox 66.0.1 on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 16.04 x64.