Open Bug 1516532 Opened 5 years ago Updated 2 years ago

Lift Nightly restriction when blocking threads in LoadLibrary*

Categories

(Core :: mozglue, enhancement, P5)

Unspecified
Windows
enhancement

Tracking

()

Tracking Status
firefox66 --- affected

People

(Reporter: ccorcoran, Unassigned)

References

(Depends on 1 open bug)

Details

We have code to block threads that start directly in LoadLibrary* variants. This is to prevent DLL injection using the CreateRemoteThread technique.

Currently, we only do this blocking on Nightly builds. I think it's safe to remove the restriction.

Original code @ https://searchfox.org/mozilla-central/rev/d6f2d4bb73446534a9231faefae05934fcd05911/mozglue/build/WindowsDllBlocklist.cpp#692

Bug 1372827 will do some refactoring to thread blocking code and add telemetry gathering, so with that we can decide if it's OK to remove the Nightly restriction.
Component: General → mozglue
Priority: -- → P5
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.