Remove toolkit/themes/osx/global/arrow/arrow-dn{,-dis}.png and replace usages with arrow-dropdown-12.svg

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P3
normal
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: ntim, Assigned: akashspi09, Mentored)

Tracking

(Blocks 1 bug, {good-first-bug})

unspecified
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 months ago
Steps to fix this bug:

1) run `hg rm` on these files:
toolkit/themes/osx/global/arrow/arrow-dn.png
toolkit/themes/osx/global/arrow/arrow-dn-dis.png

2) Remove the following lines: https://searchfox.org/mozilla-central/rev/d6f2d4bb73446534a9231faefae05934fcd05911/toolkit/themes/osx/global/jar.mn#36,39

3) Replace https://searchfox.org/mozilla-central/rev/d6f2d4bb73446534a9231faefae05934fcd05911/toolkit/themes/osx/global/toolbarbutton.css#30

with `url("chrome://global/skin/icons/arrow-dropdown-12.svg")`

4) At the same place, add the following lines:

-moz-context-properties: fill;
fill: currentColor;

5) Remove the following lines: https://searchfox.org/mozilla-central/rev/d6f2d4bb73446534a9231faefae05934fcd05911/toolkit/themes/osx/global/toolbarbutton.css#35-38
Priority: -- → P3
(Assignee)

Comment 1

3 months ago

Hey, I am Akash.Can I get assigned to this bug?

ntim, are you mentoring this? (Please don't set good-first-bug if there's no mentor.)

Flags: needinfo?(ntim.bugs)
(Assignee)

Comment 3

3 months ago

Can I still get a chance to solve this bug?

(In reply to Akash Srivastava from comment #3)

Can I still get a chance to solve this bug?

Yeah, sure.

Assignee: nobody → akashspi09
Status: NEW → ASSIGNED
(Reporter)

Updated

3 months ago
Attachment #9037337 - Flags: review?(dao+bmo)
(Reporter)

Updated

3 months ago
Mentor: ntim.bugs
Flags: needinfo?(ntim.bugs)
Comment on attachment 9037337 [details] [diff] [review]
followed the instructions to remove arrow-dn{,-dis}.png and replace with arrow-dropdown-12.svg

Looks good to me, thanks!
Attachment #9037337 - Flags: review?(dao+bmo) → review+

Comment 7

3 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/932ce6230553
Replace toolkit/themes/osx/global/arrow/arrow-dn{,-dis}.png with arrow-dropdown-12.svg. r=dao

Comment 8

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.