1516548 - header notice for private browsing/disabled addons

Status: VERIFIED FIXED

(WebExtensions :: Frontend, defect, P1)

Description

[Shane Caraveo (:mixedpuppy)]

Add header notice to top of about:addons list to inform user that extensions are disabled in private browsing.

Splitting this out from bug 1511636.  The header notices appear to be fairly broken in general, at least in styling.  Some are not width constrained, etc.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1516548 add private browsing addon notice to about:addons, r?mstriemer

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: Screen Shot 2018-12-27 at 12.12.29 PM.png

Showing banner

Comment 3

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 9033422 [details]
Screen Shot 2018-12-27 at 12.12.29 PM.png

This is an older screenshot, but the banner on top hasn't changed. Just ignore the cards below it.

Comment 4

[emanuela [ux]]

Comment on attachment 9033422 [details]
Screen Shot 2018-12-27 at 12.12.29 PM.png

Mh, it seems the text can use can use some padding on the right (4px should be enough). I will also remove the space between the icon and description (probably 4px).

Comment 5

[Shane Caraveo (:mixedpuppy)]

Attachment: Screen Shot 2019-01-14 at 4.32.56 PM.png

Some of the changes since that last screenshot already took care of the padding issue.

Comment 6

[emanuela [ux]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #5)

Created attachment 9036443 [details]
Screen Shot 2019-01-14 at 4.32.56 PM.png

Some of the changes since that last screenshot already took care of the padding issue.

This new screen looks much better, thank you for taking care of it.

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Shane, did this actually land for 66?

Comment 8

[Shane Caraveo (:mixedpuppy)]

(In reply to Liz Henry (:lizzard) (use needinfo) from comment #7)

Shane, did this actually land for 66?

This depends on bug 1511636 which is waiting final review.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1155ba90b3e7
add private browsing addon notice to about:addons, r=mstriemer,flod

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1155ba90b3e7

Comment 11

[CosminB]

Attachment: Bug1516548.png

This issue is verified as fixed on Firefox 67.0a1 (20190130094929) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached screenshot.