1516554 - Enable VR process in Nightly, on Windows

Status: RESOLVED FIXED

(Core :: WebVR, defect)

Comment 1

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1516554 - Enable VR process in Nightly Windows.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87219897a280
Enable VR process in Nightly Windows. r=kip

Comment 3

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 87219897a280 (Bug 1516554) for reftest failures on draw_rect.html and wpt assertion failures.

Backout: https://hg.mozilla.org/integration/autoland/rev/f000153a1f7f599af8c805c5d447ef81fc5f14d3

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&selectedJob=220035541&revision=87219897a280cfc756aa1cf883324512285fdd74

Reftest failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=220035541&repo=autoland&lineNumber=18029
WPT failures log: 
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=220035277&repo=autoland&lineNumber=62640
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=220038119&repo=autoland&lineNumber=7290

Comment 4

[Daosheng Mu[:daoshengmu]]

Try looks good now,
https://treeherder.mozilla.org/#/jobs?repo=try&revision=41e4d182dc08d4a6a74d3fe4671e76bd5ee4bf36
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dcf012570ac4b40579375bc651863a2d13bbf147

Comment 5

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1516554 - Part 2: Fix Oculus VR lib path assertion in try server.

Comment 6

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1516554 - Part 3: Fix VRGPUParent memory leak in the destructor.

Comment 7

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1516554 - Part 4: Fix Win 7 try fails when VR process enable but no GPU process.

Comment 8

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1516554 - Part 5: Allow VR using the existing shmem.

Comment 9

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1516554 - Part 6: Remove BackgroundHangMonitor in VRProcessChild because we will init it by XPCOM.

Comment 10

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1516554 - Part 7: Resolve MessageLoop destroy before VR IPC channels close issue.

Comment 11

[Daosheng Mu[:daoshengmu]]

An anther try is good, https://treeherder.mozilla.org/#/jobs?repo=try&revision=3aa00cee9ef0002ccd6264f95b4e7328f94af581.

Comment 12

[Daosheng Mu[:daoshengmu]]

I find a regression at Bug 1519686 about using nsString::BeginWriting() to get the lib path at OculusSession::LoadOvrLib(). We can work around it by using raw char16_t* instead of nsString.

Comment 13

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1516554 - Part 2: Fix nsTSubstring assertion when looking for Oculus VR lib.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/115387297036
Enable VR process in Nightly Windows. r=kip
https://hg.mozilla.org/integration/autoland/rev/8617fed7a3e0
Part 2: Fix nsTSubstring assertion when looking for Oculus VR lib. r=kip
https://hg.mozilla.org/integration/autoland/rev/625005dcd0b3
Part 3: Fix VRGPUParent memory leak in the destructor. r=kip
https://hg.mozilla.org/integration/autoland/rev/bff1af3da433
Part 4: Fix Win 7 try fails when VR process enable but no GPU process. r=kip
https://hg.mozilla.org/integration/autoland/rev/518dbd08c0d7
Part 5: Allow VR using the existing shmem. r=kip
https://hg.mozilla.org/integration/autoland/rev/ffe71a987b82
Part 6: Remove BackgroundHangMonitor in VRProcessChild because we will init it by XPCOM. r=kip
https://hg.mozilla.org/integration/autoland/rev/829462dca352
Part 7: Resolve MessageLoop destroy before VR IPC channels close issue. r=kip

Comment 15

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/115387297036
https://hg.mozilla.org/mozilla-central/rev/8617fed7a3e0
https://hg.mozilla.org/mozilla-central/rev/625005dcd0b3
https://hg.mozilla.org/mozilla-central/rev/bff1af3da433
https://hg.mozilla.org/mozilla-central/rev/518dbd08c0d7
https://hg.mozilla.org/mozilla-central/rev/ffe71a987b82
https://hg.mozilla.org/mozilla-central/rev/829462dca352

Comment 16

[Florin Strugariu [:Bebe] (needinfo me)]

Performance improvement

== Change summary for alert #18737 (as of Mon, 14 Jan 2019 20:00:57 GMT) ==

Improvements:

2% Base Content Heap Unclassified windows10-64-qr opt stylo 1,605,017.33 -> 1,567,746.67

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=18737

Comment 18

[Jim Mathies [:jimm]]

\o/ woot!