Closed Bug 1516554 Opened 2 years ago Closed 1 year ago

Enable VR process in Nightly, on Windows

Categories

(Core :: WebVR, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: daoshengmu, Assigned: daoshengmu)

References

Details

Attachments

(7 files, 1 obsolete file)

No description provided.
Assignee: nobody → dmu
Blocks: 1362578
Pushed by dmu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/87219897a280
Enable VR process in Nightly Windows. r=kip
Depends on: 1519686

I find a regression at Bug 1519686 about using nsString::BeginWriting() to get the lib path at OculusSession::LoadOvrLib(). We can work around it by using raw char16_t* instead of nsString.

Attachment #9035785 - Attachment is obsolete: true
Pushed by dmu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/115387297036
Enable VR process in Nightly Windows. r=kip
https://hg.mozilla.org/integration/autoland/rev/8617fed7a3e0
Part 2: Fix nsTSubstring assertion when looking for Oculus VR lib. r=kip
https://hg.mozilla.org/integration/autoland/rev/625005dcd0b3
Part 3: Fix VRGPUParent memory leak in the destructor. r=kip
https://hg.mozilla.org/integration/autoland/rev/bff1af3da433
Part 4: Fix Win 7 try fails when VR process enable but no GPU process. r=kip
https://hg.mozilla.org/integration/autoland/rev/518dbd08c0d7
Part 5: Allow VR using the existing shmem. r=kip
https://hg.mozilla.org/integration/autoland/rev/ffe71a987b82
Part 6: Remove BackgroundHangMonitor in VRProcessChild because we will init it by XPCOM. r=kip
https://hg.mozilla.org/integration/autoland/rev/829462dca352
Part 7: Resolve MessageLoop destroy before VR IPC channels close issue. r=kip

Performance improvement

== Change summary for alert #18737 (as of Mon, 14 Jan 2019 20:00:57 GMT) ==

Improvements:

2% Base Content Heap Unclassified windows10-64-qr opt stylo 1,605,017.33 -> 1,567,746.67

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=18737

Duplicate of this bug: 1519686

\o/ woot!

See Also: → 1524929
You need to log in before you can comment on or make changes to this bug.