Closed Bug 1516567 Opened 11 months ago Closed 11 months ago

Fix property spec assertions to not assume a getter

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

We assert that a non-selfhosted JSPropertySpec has a getter and has a native setter if it has a setter at all.

But there can be cases when a JSPropertySpec only has a setter and has no getter.  This happens with "href" on cross-origin Location, for example.
Summary: Fix property array assertions → Fix property spec assertions to not assume a getter
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/491828d457fc
Fix JSPropertySpec assertions to deal with not having a getter.  r=jandem
https://hg.mozilla.org/mozilla-central/rev/491828d457fc
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Depends on: 1518812

This was accidentally backed out by the patch for bug 1517624 (see bug 1518812).

You need to log in before you can comment on or make changes to this bug.