1516634 - [Content Blocking] Some elements inside the “Site information” panel are not visible enough on dark theme on Ubuntu

Status: RESOLVED DUPLICATE of bug 1509631

(Firefox :: Theme, defect)

Description

[Anca Soncutean, Desktop QA]

Attachment: screenshot issue.png

[Affected versions]: 
- 65.0b7 (20181227144402)
- 66.0a1 (20181227215704)

[Affected platforms]:
- Ubuntu 18.04 x64
- Ubuntu 16.04 x32

[Steps to reproduce]:
1. Set the theme on Dark (Menu - Customize)
2. Go to a webpage that activates Content Blocking
(eg. https://www.reddit.com/)
3. Click the shield icon inside the URL bar
4. Hover on the “Show connection details” arrow
5. Select Trackers/Cookies option and keep the left click pressed

[Expected result]:
- [4][5] The elements in cause are clear and visible.

[Actual result]:
- [4][5] The contrast should be improved, the elements in focus are not visible enough.

[Regression range]: 
- The issue regarding the elements mentioned at step [4] and [5] regressed from different bugs:

 [4] “Show connection details” arrow
Last good revision: 4ff11c25342dc8d18d406a2a82af27896c1d9714
First bad revision: b53757428f6d04f9ae00296a8fbcd65f6343c2e6
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4ff11c25342dc8d18d406a2a82af27896c1d9714&tochange=b53757428f6d04f9ae00296a8fbcd65f6343c2e6
	
 [5] Trackers and Cookies buttons
Last good revision: d7336bdef207654c48c3e0c6c976f3ed65fe5ccd
First bad revision: 9d911745f1d14397a313ff695cec0901316db1d7
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=d7336bdef207654c48c3e0c6c976f3ed65fe5ccd&tochange=9d911745f1d14397a313ff695cec0901316db1d7

Comment 1

[Dão Gottwald [:dao]]

(In reply to Anca Soncutean [:Anca], Desktop Release QA from comment #0)
>  [4] “Show connection details” arrow
> Last good revision: 4ff11c25342dc8d18d406a2a82af27896c1d9714
> First bad revision: b53757428f6d04f9ae00296a8fbcd65f6343c2e6
> Pushlog:
> https://hg.mozilla.org/integration/autoland/
> pushloghtml?fromchange=4ff11c25342dc8d18d406a2a82af27896c1d9714&tochange=b537
> 57428f6d04f9ae00296a8fbcd65f6343c2e6

This range doesn't seem to make sense.

Comment 2

[Anca Soncutean, Desktop QA]

(In reply to Dão Gottwald [::dao] from comment #1)
> This range doesn't seem to make sense.

Yes, you are right, sorry for the inconvenience. I double checked the regression range on both the affected Ubuntu versions.. Both pointed to the following: 

Last good revision: 4f04e189f2bbce09691a4877e45e3bf025402e4d
First bad revision: 948718214f0b2ec4c9d8b6fca73fbca50c211239
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4f04e189f2bbce09691a4877e45e3bf025402e4d&tochange=948718214f0b2ec4c9d8b6fca73fbca50c211239

Comment 3

[(no longer active)]

Looks like a regression from bug 1473922.  Dao, do you have time to take a look?

Comment 4

[Tim Nguyen :ntim]

Is the first issue fixed as of bug 1513029 ? If so, can we mark this bug as a duplicate of bug 1509631 ?

Comment 5

[Ryan VanderMeulen [:RyanVM]]

I don't think this needs to be tracked for 65, but I'll accept a low-risk patch still.

Comment 6

[(no longer active)]

(In reply to Tim Nguyen :ntim from comment #4)
> Is the first issue fixed as of bug 1513029 ?

If by first issue you mean the hover state for Trackers/Cookies, that seems to be fixed on Linux.

> If so, can we mark this bug as
> a duplicate of bug 1509631 ?

I don't know...  https://bugzilla.mozilla.org/show_bug.cgi?id=1509631#c2 makes me think that bug is Mac only?  But I can certainly reproduce it on Linux too.  FWIW the reverse of that icon that we have in the "Site Security" header when you click on that button to allow the user to go back doesn't seem to be affected by the same issue, so it seems like on Linux the issue is specific to the right chevron icon next to "Connection".

Comment 7

[Tim Nguyen :ntim]

(In reply to :Ehsan Akhgari from comment #6)
> (In reply to Tim Nguyen :ntim from comment #4)
> > Is the first issue fixed as of bug 1513029 ?
> 
> If by first issue you mean the hover state for Trackers/Cookies, that seems
> to be fixed on Linux.
> 
> > If so, can we mark this bug as
> > a duplicate of bug 1509631 ?
> 
> I don't know...  https://bugzilla.mozilla.org/show_bug.cgi?id=1509631#c2
> makes me think that bug is Mac only?  But I can certainly reproduce it on
> Linux too.  FWIW the reverse of that icon that we have in the "Site
> Security" header when you click on that button to allow the user to go back
> doesn't seem to be affected by the same issue, so it seems like on Linux the
> issue is specific to the right chevron icon next to "Connection".

Yeah, the Linux rule causing this is [0] but the fix for Mac and Linux are pretty much the same: adding !important at [1] with a comment explaining why.

[0]: https://searchfox.org/mozilla-central/source/toolkit/themes/linux/global/button.css#36-38
[1]: https://searchfox.org/mozilla-central/rev/bcc0fe1081dc4f84fc5fdfebe0d2de8c075a4e2c/browser/themes/shared/controlcenter/panel.inc.css#117

Comment 8

[(no longer active)]

I see.  In that case then maybe we should dupe the bugs?  Up to you.  :-)