1516646 - Start recording the gecko HG revision in the wr.txt file in WR captures

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Kartikaya Gupta (email:[e-mail])]

Once we start pushing WR patches directly to m-c, the gfx/webrender_bindings/revision.txt file will be obsolete. However it still serves a useful function in identifying the version of code captures are generated from. It would be good to have this file contain the m-c revision or some equivalent identifier.

For now we can have it contain both the revision.txt contents, and the gecko hg revision. Once we make m-c the canonical repo, we can drop revision.txt and just keep the hg revision.

For developers using a full gecko tree it should be easy enough to just update to the indicated revision and build wrench for investigating captures. For developers using the standalone WR repo it might be a bit more of a burden but the steps to find the equivalent github revision would be (a) find the most recent m-c commit prior to the one indicated in wr.txt that touched anything in gfx/wr, and (b) look for a commit in the github repo that is the equivalent of that m-c commit. Presumably when we mirror m-c commits to github we'll include the m-c revision IDs in the github commits which will facilitate (b).

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Try push at https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=2fd8cdbff69658ceeb010455bd3c7c363367d773 has a patch. Captures recorded from that build include the m-c rev.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1516646 - Write the Gecko mercurial revision into captures as well. r?jrmuizel

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Now using GECKO_HEAD_REV instead of MOZ_SOURCE_CHANGESET: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=bd7a48f195fbd90462a3dc710cdf17eda362c2a6

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec8108d8f489
Write the Gecko mercurial revision into captures as well. r=jrmuizel

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/ec8108d8f489