Start recording the gecko HG revision in the wr.txt file in WR captures

RESOLVED FIXED in Firefox 66

Status

()

enhancement
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: kats, Assigned: kats)

Tracking

Other Branch
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment)

Once we start pushing WR patches directly to m-c, the gfx/webrender_bindings/revision.txt file will be obsolete. However it still serves a useful function in identifying the version of code captures are generated from. It would be good to have this file contain the m-c revision or some equivalent identifier.

For now we can have it contain both the revision.txt contents, and the gecko hg revision. Once we make m-c the canonical repo, we can drop revision.txt and just keep the hg revision.

For developers using a full gecko tree it should be easy enough to just update to the indicated revision and build wrench for investigating captures. For developers using the standalone WR repo it might be a bit more of a burden but the steps to find the equivalent github revision would be (a) find the most recent m-c commit prior to the one indicated in wr.txt that touched anything in gfx/wr, and (b) look for a commit in the github repo that is the equivalent of that m-c commit. Presumably when we mirror m-c commits to github we'll include the m-c revision IDs in the github commits which will facilitate (b).
Assignee: nobody → kats

Comment 4

5 months ago
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec8108d8f489
Write the Gecko mercurial revision into captures as well. r=jrmuizel

Comment 5

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ec8108d8f489
Status: NEW → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.