1516655 - browserAction forWindow checks

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P2)

Description

[Shane Caraveo (:mixedpuppy)]

While working on incognito support and fixing an issue in CUI code, I noticed that we often have code in ext-browserAction that does something like:

let widget = widget.forWindow(window);
if (!widget) ...

The issue here is, forWindow[1] always returns a widgetWrapper instance which contains the node if one exists[2].  I believe the checks should be:

if (!widget.node) ...

We should review our use of CUI and make sure we're handling this correctly.

[1] https://searchfox.org/mozilla-central/rev/8a135a9c5a96b59269f544fcaee76d8fd5a7026a/browser/components/customizableui/CustomizableUI.jsm#4014

[2] https://searchfox.org/mozilla-central/rev/8a135a9c5a96b59269f544fcaee76d8fd5a7026a/browser/components/customizableui/CustomizableUI.jsm#4067

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1516655 fix widget.node checks in browserAction code, r?rpl

Comment 2

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=869766cdc77f2af838d38cb4cf1f00092cac26cc

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfd9ddf7b03b
fix widget.node checks in browserAction code, r=rpl

Comment 4

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/bfd9ddf7b03b

Comment 5

[Vlad Jiman]

Hi, will this bug require manual validation from the QA team? if so please specify how to correctly validate it, thanks!

Comment 6

[Shane Caraveo (:mixedpuppy)]

Existing tests should handle it just fine.