MOZILLA_1_0_BRANCH is now using a version of NSPR marked as "4.2 Beta". It is almost the same as NSPR 4.2 RTM, plus a few fixes from NSPR 4.2.1. I would like to check in the remaining NSPR 4.2 and 4.2.1 fixes on the MOZILLA_1_0_BRANCH so that Mozilla 1.0.1 will be using NSPR 4.2.1.
Note that for ease of code review, I omitted the changes to the NSPR files that are not used by Mozilla. I would like to check in all the fixes, but am open to excluding the ones that you consider high risk.
Severity: normal → minor
Priority: -- → P2
Target Milestone: --- → mozilla1.0.1
Is it bad to have the config.guess and config.sub changes out of sync with the other copies in the Mozilla tree? I recall seawood saying something like that. I also recall seawood getting approval to land that patch anyway...
a=blizzard on behalf of drivers for the 1.0 branch. Please make sure that you work with cls to get the config.* files figured out, as dbaron says.
I can exclude the config.guess and config.sub changes from this bug and handle them separately.
Status: NEW → ASSIGNED
No visible user benefit = adt1.0.1-.
The resolution should not be FIXED. Reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → WONTFIX
Yay, my users are going to be impacted by a beta nspr release.
I have a different patch. The new patch is much smaller and easier to assess its risk. I am going to present the patch in two parts. This is Part I, which consists of the changes that affect Mozilla. 1. A fix for bug 135008. 2. New NSPR version number "4.2.1 Beta".
Attachment #87595 - Attachment is obsolete: true
Part II of the new patch consists of the changes that do not affect Mozilla. 1. Update the NSPR binary distribution packaging script for NSPR 4.2.1. This script is not used by Mozilla. 2. Remove a blank line from a header file that is not included by NSPR. 3. Fix incorrect assertions in PR_SendFile. Mozilla does not use the PR_SendFile function. 4. Update a test program for NSPR 4.2.1. The test program is not shipped with Mozilla.
Attachment #88516 - Attachment is obsolete: true
Reopened the bug and requesting mozilla1.0.1 and adt1.0.1 approvals for the new patch.
Adding adt1.0.1+ on behalf of the adt for checkin to the 1.0 branch. Please get drivers approval before checking in. When you check this into the branch, please change the mozilla1.0.1+ keyword to fixed1.0.1
a=blizzard on behalf of drivers for the 1.0 branch.
The new patch has been checked into the MOZILLA_1_0_BRANCH.
stephen - do you know how to verify this fix for branch?
I'm not 100% sure, exactly: C:\branch>cvs co -r MOZILLA_1_0_BRANCH mozilla/client.mk U mozilla/client.mk C:\branch>cd mozilla C:\branch\mozilla>make -f client.mk make: c:/branch/mozilla/build/unix/abs2rel.pl: Command not found checkout start: Sat Aug 24 21:30:41 2002 cvs -q -z 3 co -r MOZILLA_1_0_BRANCH -P mozilla/client.mk mozilla/build/unix/modules.mk make: c:/branch/mozilla/build/unix/abs2rel.pl: Command not found make: Entering directory `/cygdrive/c/branch' cvs -q -z 3 co -P -r MOZILLA_1_0_BRANCH mozilla/nsprpub I thought I could check the NSPR module under LXR, but it appears to be one entity, that is: not having a separate MOZILLA_1_0_BRANCH entry like /mozilla does under http://lxr.mozilla.org by which to query for changes.
You can verify as follows: cvs co -r MOZILLA_1_0_BRANCH mozilla/nsprpub/pr/include/prinit.h Open prinit.h and verify that the value of PR_VERSION is "4.2.1".
#define PR_VERSION "4.2.1" #define PR_VMAJOR 4 #define PR_VMINOR 2 #define PR_VPATCH 1 #define PR_BETA PR_FALSE Verified FIXED for the MOZILLA_1_0_BRANCH.
You need to log in before you can comment on or make changes to this bug.