1516741 - Provide Thunderbird MSI package

Status: RESOLVED FIXED

(Thunderbird :: Installer, enhancement)

Description

[Rob Lemley [:rjl]]

+++ This bug was initially created as a clone of Bug #274624 +++

Follow-up bug for bug 274624 to track the fixes that need to go in before completion.

- Work in beetmover and bouncerscript (maintained by releng bug 1516475 and bug 1516542)
- Fix the application name reported by the MSI noted at bug 274624 comment 15.
- The WIX file has a couple of GUID fields. As noted at ug 1475510 comment 8, Firefox opted to generate new GUIDs specifically for the MSI installer rather than reuse ones from the EXE installer. We need to generate some as well and update the WIX.

@mkmelkin: IIRC, you had told me the Vendor value in application.ini should be empty. Should that be the case here as well?

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1516741 - Use buildconfig to populate BrandFullname in MSI installer. r?aki

Thunderbird is building an MSI installer using the recently added support that
Firefox added.

The BrandFullname variable is hardcoded to "Firefox". This patch gets it from
buildconfig.

Comment 2

[Rob Lemley [:rjl]]

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e2888f6a77834cccc0e100cc968ce892dcd1722

Try-comm-central:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=3aa394cae57ab9fb7ecacc1165b7071ccea78e03

Comment 3

[Magnus Melin [:mkmelin]]

Yes, the Thunderbird vendor should be empty

Comment 4

[Rob Lemley [:rjl]]

Attachment 9033612 [details] didn't work out so well unfortunately since the buildconfig is no longer available when the repackage task For right now I've hardcoded the right values into our copy of installer.wxs.

Comment 5

[Rob Lemley [:rjl]]

Attachment: installer.wxs changes for Thunderbird

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 9033793 [details] [diff] [review]
installer.wxs changes for Thunderbird

Review of attachment 9033793 [details] [diff] [review]:
-----------------------------------------------------------------

The Firefox Nightly MSI shows "Mozilla Firefox" and not "Nightly". So it's okay to hard code with Thunderbird and not to differ between the channels.

::: mail/installer/windows/msi/installer.wxs
@@ +5,5 @@
>  <!-- The version field only supports MSI version numbers, which cannot include
>       letters, and therefore cannot represent our version numbers. Set it to all
>       zeros to show it isn't valid, and add the real version to the Name. -->
> +<!-- For Thunderbird, the Manufacturer field (aka Vendor) is empty. -->
> +<Product Name="Thunderbird $(var.Version) $(var.Architecture) $(var.AB_CD)"

Name should be "Mozilla Thunderbird".

Comment 7

[Rob Lemley [:rjl]]

Magnus, just for clarification. The "Vendor" field is empty, should the "Product Name" field be "Thunderbird" or "Mozilla Thunderbird"?

Comment 8

[Magnus Melin [:mkmelin]]

It should be $(var.BrandFullName) which is Mozilla Thunderbird. But I think you should rather fix whatever buildconfig bug there is that doesn't make var.BrandFullName be Firefox for us. If that's not working properly there is bound to be other subtle or non-subtle bugs around here.

Comment 10

[Rob Lemley [:rjl]]

Making progress. Current issue from the WiX compiler:

With "Manufacturer" set to an empty string WiX produces:

error CNDL0006 : The Product/@Manufacturer attribute's value cannot be an empty string. If a value is not required, simply remove the entire attribute.

Removing the attribute produces:

error CNDL0010 : The Product/@Manufacturer attribute was not found; it is required.

Comment 11

[Rob Lemley [:rjl]]

Attachment: finalize_msi.patch

This patch actually works and produces MSI files with the correct names.

That Manufacturer value has to be something apparently. An empty string yields an error, as does a string that's just a space. This makes it an *.

Built installers at
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=ea16817c9fd7508323f0bd6e5fecf1f31f1bdb4a

It installed under Wine at least.

Comment 12

[Richard Marti (:Paenglab)]

Comment on attachment 9060989 [details] [diff] [review]
finalize_msi.patch

LGTM and it installed under Win 7 with showing the correct name in title.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/245790807d1f
Finalize MSI packaging for Thunderbird. r=Paenglab

Comment 14

[Sean M. Pappalardo]

Suggestion for the Manufacturer field: use something like "The Thunderbird Team", if it actually appears anywhere.