Closed Bug 1516743 Opened 9 months ago Closed 8 months ago

[wpt-sync] Sync PR 14687 - [LayoutNG] Fix SVG replaced element sizes

Categories

(Core :: SVG, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 14687 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14687
Details from upstream follow.

Aleks Totic <atotic@chromium.org> wrote:
>  [LayoutNG] Fix SVG replaced element sizes
>  
>  The old code made an incorrect assumption that if Legacy's
>  IntrinsicSizingInfo did not compute width/height, the fallback
>  should be LayoutBox::IntrinsicSize.
>  
>  I thought I was being clever, and was trying to keep sizing computation
>  logic out of LayoutBox. Unfortunately, not enough information
>  is exposed by LayoutBox to compute ReplacedSize from raw
>  IntrinsicSize, and IntrinsicSizingInfo must be used.
>  
>  The correct fix is to use ConstraintSpace::AvailableSize if
>  IntrinsicSizingInfo is unavailable.
>  
>  Bug: 916387
>  Change-Id: Ib58bbd4775aa9fe1129bc5613d1652123b12670e
>  Reviewed-on: https://chromium-review.googlesource.com/1392367
>  WPT-Export-Revision: 76f7b398449bb0af974083e13f7658474a414130
Component: web-platform-tests → SVG
Product: Testing → Core
Ran 1 tests
PASS   : 1
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ff6bc6b7d90
[wpt PR 14687] - [LayoutNG] Fix SVG replaced element sizes, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/939a9502b7ab
[wpt PR 14687] - [LayoutNG] Fix SVG replaced element sizes, a=testonly
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.