Closed Bug 1516788 Opened 10 months ago Closed 10 months ago

Move SMILAnimationFunctions to the mozilla namespace

Categories

(Core :: SVG, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: longsonr, Assigned: longsonr)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → longsonr
Attachment #9033646 - Flags: review?(bbirtles)
Attached patch patchSplinter Review
Attachment #9033646 - Attachment is obsolete: true
Attachment #9033646 - Flags: review?(bbirtles)
Attachment #9033647 - Flags: review?(bbirtles)
Comment on attachment 9033647 [details] [diff] [review]
patch

Review of attachment 9033647 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this. It looks good to me. I tend to use include "mozilla/SMILAnimationFunction.h" when we're exporting under 'mozilla' even though the header in question is in the same directory. I'm not sure if there's any official guidance on this but it seems to be pretty common.

::: dom/smil/SMILSetAnimationFunction.h
@@ +8,4 @@
>  #define NS_SMILSETANIMATIONFUNCTION_H_
>  
>  #include "mozilla/Attributes.h"
> +#include "SMILAnimationFunction.h"

I guess this should probably be mozilla/SMILAnimationFunction.h to be consistent.
Attachment #9033647 - Flags: review?(bbirtles) → review+
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d676262c77b9
Move SMILAnimationFunctions to the mozilla namespace r=bbirtles
https://hg.mozilla.org/mozilla-central/rev/d676262c77b9
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.