1516813 - Port Bug 1472557 Remove the "scrollbox" anonymous element from "richlistbox"

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Jorg K (CEST = GMT+2)]

As per bug 1472557 comment #7 (quote):

===
Once this lands, the CSS changes in https://phabricator.services.mozilla.com/D15388 will need to be ported to TB - mostly this is flattening `richlistbox > scrollbox` selectors to `richlistbox` (see https://searchfox.org/comm-central/search?q=%3E+scrollbox&path=).

In some cases margins that were previously split between the two elements will need to be merged into just `richlistbox` (see toolkit/themes/linux/mozapps/update/updates.css).
===

Richard, can you please take this.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1516813-flat-richlistbox.patch

First it looked easy. But then on Mac in chat the contactListbox was tricky with the Mac special list transparency and the borders. So I needed a bit more work there and it works now.

In the attachmentlist-vertical binding, which is used in the composer attachment bucket, I removed the scrollbox too.

The attachmentlist-horizontal binding, used in the message pane, still uses it because here it is much complicated because it expands when it would overflow. So I leaved it.

Comment 2

[Jorg K (CEST = GMT+2)]

Wow, what a big patch. So how do I review this? Apply https://hg.mozilla.org/integration/mozilla-inbound/rev/8b2453d488ae and make sure it all still looks good? So where do I need to look?

Comment 3

[Richard Marti (:Paenglab)]

Yes. The attachment bucket in composer window should look the same (I fixed on Windows the margin and the selected attachmentitem colour too, which was no more right after the loading of some m-c styles as document) and also the overflowing should look right.

Gloda autocomplete should look as before.

And the chat should look correctly, especially the selected channel/contact should look like a tab and don't have a border on the right (the issue on Mac). So also chat should look as before.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 9033694 [details] [diff] [review]
1516813-flat-richlistbox.patch

I looked at it with the M-C change applied and it looked good to me. (I'm not really a great friend of CSS reviews.)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/992cb1d8b84f
Port Bug 1472557: Remove the "scrollbox" anonymous element from "richlistbox". r=jorgk DONTBUILD