Closed Bug 1516816 Opened 11 months ago Closed 3 months ago

Upload releases and candidates of calendar extensions to ftp.m.o

Categories

(Thunderbird :: Build Config, defect, P2)

defect

Tracking

(thunderbird_esr6868+ fixed, thunderbird69 fixed, thunderbird70 fixed)

RESOLVED FIXED
Thunderbird 70.0
Tracking Status
thunderbird_esr68 68+ fixed
thunderbird69 --- fixed
thunderbird70 --- fixed

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

Attachments

(2 files, 1 obsolete file)

We should be able to use the push-to-release task to also upload Lightning and GData Provider to the archive. I guess this might require creating a Lightning artifact, which is easy enough, and there is already a GData artifact.

I'll work on this and try to get it going before 68 goes out.

Assignee: nobody → rob

I have, among the many things on the back burner, a patch that results in lightning.xpi and gdata-provider.xpi artifacts. It should just be a case of hooking them up to thunderbird_candidates.yml. I don't think the L10n repackage step is going to cope with it though.

Type: enhancement → defect
Priority: -- → P1
Attached patch gdata-provider-to-ftp.patch (obsolete) — Splinter Review
This just gets the gdata-provider.xpi for en-US up in the FTP area to
avoid passing out the URL to the Taskcluster artifact in the release
notes.

The try job I ran did the right thing, the result can be seen at
http://ftp.stage.mozaws.net/pub/thunderbird/nightly/latest-try-comm-central/

The filename can be changed, I've set it to thunderbird-70.0a1.gdata-provider.en-US.xpi

I am fast tracking at least this piece of this bug so it gets into 68.0.
Attachment #9080968 - Flags: review?(geoff)
Attachment #9080968 - Flags: feedback?(philipp)
Attachment #9080968 - Flags: feedback?(mkmelin+mozilla)
Comment on attachment 9080968 [details] [diff] [review]
gdata-provider-to-ftp.patch

Review of attachment 9080968 [details] [diff] [review]:
-----------------------------------------------------------------

The idea's right, but I have too many questions.

::: taskcluster/comm_taskgraph/manifests/thunderbird_candidates.yml
@@ +330,5 @@
> +        description: "Google data provider XPI (en-US only)"
> +        all_locales: false  # Uses default_locale only
> +        from:
> +            - build
> +        pretty_name: thunderbird-${version}.gdata-provider.${locale}.xpi

I think this should be gdata-provider-${version}.${locale}.xpi.

@@ +331,5 @@
> +        all_locales: false  # Uses default_locale only
> +        from:
> +            - build
> +        pretty_name: thunderbird-${version}.gdata-provider.${locale}.xpi
> +        checksums_path: ${path_platform}/xpi/${locale}.xpi

That's surely not right … ?

@@ +333,5 @@
> +            - build
> +        pretty_name: thunderbird-${version}.gdata-provider.${locale}.xpi
> +        checksums_path: ${path_platform}/xpi/${locale}.xpi
> +        only_for_platforms:
> +            - linux64-shippable

Do we not want the other platforms too? Sure, they're all the same, but it seems a bit odd.

::: taskcluster/comm_taskgraph/manifests/thunderbird_nightly.yml
@@ +397,5 @@
> +        all_locales: false  # Uses default_locale only
> +        from:
> +            - build
> +        pretty_name: thunderbird-${version}.gdata-provider.${locale}.xpi
> +        checksums_path: thunderbird-${version}.gdata-provider.${locale}.xpi

Again with the name.

@@ +403,5 @@
> +            - linux64-shippable
> +        destinations:
> +            - ${year}/${month}/${upload_date}-${branch}
> +            - latest-${branch}
> +            - latest-${branch}-l10n

I'm not sure it's useful in the latest-comm-central-l10n directory.
Attachment #9080968 - Flags: review?(geoff) → review-
Most review comments addressed.

- Use "${locale}" in original filename rather than en-US (tested, does work)
- Sticking with only building for linux64 platform to make things easier
  for anyone looking to download from FTP and whoever mmay upload to ATN.
- Dropped the "thunderbird-${version}" from pretty-names
- Keeping the destination directories the same for both nightly and
  release builds, including the latest-${branch}-l10n one. The other
  en-US specific files go there, this might as well too.

No try job run to verify, trees currently closed.
Attachment #9081687 - Flags: review?(geoff)
Attachment #9080968 - Attachment is obsolete: true
Attachment #9080968 - Flags: feedback?(philipp)
Attachment #9080968 - Flags: feedback?(mkmelin+mozilla)

This looks fine but your BMR task is still pending.

Attachment #9081687 - Flags: review?(geoff) → review+

(In reply to Geoff Lankow (:darktrojan) from comment #6)

This looks fine but your BMR task is still pending.

I assume you're referring to
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=603187b732f068acb77c5ef9b50ccd6298cd0c68
and that has completed successfully now.

I guess you want this backported, so please set the flags.

Flags: needinfo?(rob)
Comment on attachment 9081687 [details] [diff] [review]
gdata-provider-to-ftp.patch

I did it for you in case we're building another beta soonish, so it doesn't get forgotten.
Flags: needinfo?(rob)
Attachment #9081687 - Flags: approval-comm-esr68?
Attachment #9081687 - Flags: approval-comm-beta?

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/0cbb5a644bf1
Upload gdata-provider artifact to FTP server. r=darktrojan DONTBUILD

Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 70.0

From where could I obtain a copy of a gdata-provider.en-US.xpi that is compatible with the TB 68.x branch?

The latest builds for 68.x were produced 12 days before you pushed it. When trying to use the 68.0b5 candidates, the add-on manager claims that "provider for google calendar is incomaptible with 68.0".

Flags: needinfo?(rob)

There is a fresh build of TB 68 on the c-esr68 treeherder. Click on a B and get it from the artifacts. Or use TB 68 b5 and follow the link in the release notes.

Thanks Jörg, I installed using the link from https://www.thunderbird.net/en-US/thunderbird/68.0beta/releasenotes/ and it's working.

Status: RESOLVED → REOPENED
Flags: needinfo?(rob)
Keywords: leave-open
Resolution: FIXED → ---
Priority: P1 → P2
Attachment #9081687 - Flags: approval-comm-esr68?
Attachment #9081687 - Flags: approval-comm-esr68+
Attachment #9081687 - Flags: approval-comm-beta?
Attachment #9081687 - Flags: approval-comm-beta+

TB 69 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/9344b60b89f062d9f49f916aca27b65180ee4f90

Reopened since there is more to come. From IRC:
20:44:32 - rjl: ... we want to have the lightning extension built the same way as gdata provider and go on ftp

Depends on: 1569539
Version: unspecified → 68

Oops, I've just broken this on trunk. I knew I had to change the name of the gdata package in the upload manifests, but forgot. I was coming back here to add Lightning anyway, so I'll fix it.

Attachment #9083860 - Flags: review?(rob)
Comment on attachment 9083860 [details] [diff] [review]
1516816-upload-xpis-1.diff

Review of attachment 9083860 [details] [diff] [review]:
-----------------------------------------------------------------

Ahh I see, took a minute to realize that comment 18 was a link to your try build. :) Bug 1569539 already landed which is the breaking change mentioned in comment 16.
Attachment #9083860 - Flags: review?(rob) → review+

Yeah, sorry, those comments were a little bit cryptic.

Assignee: rob → geoff

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e1a0f9d5e69c
Upload lightning and gdata-provider artifacts to FTP server (adjustment after bug 1569539). r=rjl

Status: REOPENED → RESOLVED
Closed: 4 months ago3 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.