1516819 - [CSD] Popup window created by browser.windows.create loses title bar after session restore

Status: RESOLVED DUPLICATE of bug 1564738

(Firefox :: Extension Compatibility, defect)

Description

[gwarser]

Attachment: beta-bad.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

- fresh Firefox profile
- enable "Restore previous session" in Preferences, close tab
- disable title bar in Customize..., close tab
- Add-ons -> Extensions, search for and install uBlock Origin 1.17.4
- click on uBlock Origin icon in toolbar and click "Open the logger" icon (second from the right, just below "power" button)
- close main window
- close uBO logger window
- reopen Firefox


Actual results:

Main window and uBO logger window opens.
Logger window title bar and buttons missing.


Expected results:

Title bar and minimize/maximize/close buttons should be present.

Related uBO code https://github.com/gorhill/uBlock/blob/c3b0fd31f64bd7ffecdd282fb1208fe07aac3eb0/platform/chromium/vapi-background.js#L497

Comment 1

[gwarser]

Attachment: ubo-1.17.4, fx-beta.png

This is screenshot from uBO 1.17.4, previous was from dev build.

My system is Manjaro KDE

Comment 2

[Kanchan Kumari QA]

Attachment: uBlock Origin.PNG

I couldn't reproduce this issue on Ubuntu 16.04

uBlock Version 1.17.4

User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:66.0) Gecko/20100101 Firefox/66.0

I see no difference in Logger window title bar/ buttons before or after STR from comment 1. I don't see uBlock icon (as mentioned in comment 1) before or after. Please see the attached image.

I am placing this under Firefox: Extensions comparability so someone can look into this.

Comment 3

[gwarser]

I can also reproduce on:

uBO 1.17.4 on Firefox 64 on Lubuntu lxqt 18.10 (buttons present, but no title bar)
uBO 1.17.4 on Firefox 65 on Lubuntu lxqt 18.10

and

uBO 1.17.4 on Firefox 65 on Mint kde 18.3

but not on

uBO 1.17.4 on Firefox 64 on Mint kde 18.3


(these systems have not been updated for few months)

Comment 4

[gwarser]

Attachment: ubo 1.17.4 on Fx 64 on lubuntu lxqt.png

Comment 5

[gwarser]

This also happens for popups opened by window.open() with location=0 option.
Test: https://codepen.io/anon/pen/vvQBKJ (popup opens after click).

location=0 option is blocked by default, needs to be allowed in about:config first: dom.disable_window_open_feature.location;false.

65 and 66 - both, drag space and window buttons are missing
64 - no drag space, window buttons displayed over content

Maybe guys from https://bugzilla.mozilla.org/show_bug.cgi?id=1283299 should look at this?

Comment 6

[gwarser]

Similar to https://bugzilla.mozilla.org/show_bug.cgi?id=1481634

Comment 7

[gwarser]

https://www.reddit.com/r/uBlockOrigin/comments/cefu61/how_do_i_close_the_logger/

Comment 8

[DA]

I reproduced it.

(1) Open Firefox and uBlock Origin monitoring window
(2) Close Firefox windows and next uBlock
(3) Again open Firefox with restore previous session
(4) And now uBlock has opened with but without minimize, shrink and close buttons in the upper right corner

Link: https://github.com/gorhill/uBlock/issues/3761

Comment 9

[gwarser]

I think this is also regression from bug 1448286 similar to bug 1481634 and bug 1564738

I tried checking this using mozregression --good 2018-03-10 --bad 2018-04-05 and was able to reduce window to [2018-03-22, 2018-03-23]
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8bf380faae74e4921be6000496ca09d4a2c44e8d&tochange=d7b0d0e7228da9d690df6f105b865db973789c34 other builds are missing.