Closed Bug 1516867 Opened 11 months ago Closed 10 months ago

Clamp selection color saturation between 0 and 255 in nsLookAndFeel.mm

Categories

(Core :: Widget: Cocoa, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox65 --- fixed
firefox66 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

Details

Attachments

(1 file)

If the factor increases, or if the OS increases the saturation. It's possible that the saturation goes above 255, which gives a bogus color when converted back to RGB.
Attachment #9033689 - Attachment description: Bug 1516867 - Clamp selection color saturation between 0 and 255 in nsLookAndFeel.mm. → Bug 1516867 - Clamp selection color saturation between 0 and 255 in nsLookAndFeel.mm. r=mstange
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f6a85c2b0dff
Clamp selection color saturation between 0 and 255 in nsLookAndFeel.mm. r=mstange

Comment on attachment 9033689 [details]
Bug 1516867 - Clamp selection color saturation between 0 and 255 in nsLookAndFeel.mm. r=mstange

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1486204

User impact if declined: None, just makes the current code more sane in case the OS starts giving different values.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce:

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Trivial change

String changes made/needed: None

Attachment #9033689 - Flags: approval-mozilla-beta?
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66

Comment on attachment 9033689 [details]
Bug 1516867 - Clamp selection color saturation between 0 and 255 in nsLookAndFeel.mm. r=mstange

[Triage Comment]
Improvement to the patch landed in bug 1486204 to make us more resilient to changed OS values. Approved for 65.0b10.

Attachment #9033689 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.