15169 - Autofill item in Pref UI not needed anymore?

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect, P3)

Description

[Paul MacQuiddy]

The 'Enabling Prefill of Forms' pref in Pref UI doesn't seem relevant anymore,
with the new way of 'capturing' forms. You may still be using the pref it sets
for some logic, I don't know.

If you agree this should be taken out, you can just re-assign this to Matt.

Comment 1

[Stephen P. Morse]

I agree with you that this should be taken out.  But before we can do so, there
is some very minor cleanup that needs to be done to wallet.cpp so that it no
longer tests for this pref.

Comment 2

[Stephen P. Morse]

I just checked in the minor cleanup to wallet.cpp.  So now it's up to matt to
remove the pref from the UI.  Reassigning.

Comment 3

[chris hofmann]

I think we can get by without doing this for m10.
there are still many things in the pref ui not hooked up to work as expected.
this single change doesn't buy us a whole lot.
in m11 a good deal of clean up is coming.
matt is out on vacation.

i'd intertain other ideas but for now marking this m11.

Comment 4

[Paul MacQuiddy]

Yes, we can live w/o this for m10.

Comment 5

[matt]

Need a code review

RCS file: /cvsroot/mozilla/xpfe/components/prefwindow/resources/content/pref-adv
anced.xul,v
retrieving revision 1.14
diff -r1.14 pref-advanced.xul
102,114d101
<                       <html:div>
<                       <html:label for="pref:string:wallet.Server" accesskey="c
" tabindex="0">
<                               &server.label;
<                       </html:label>
<                       <html:input name="Wallet Server:" type="text"   id="pref
:string:wallet.Server" size="25" />
<                       </html:div>
<                       <spring style="height:10px" />
<       </html:fieldset>
<     </box>
<
<
<       <box align="vertical" style="width: 100%;">
<       <html:fieldset style="width: 100%;">

Comment 6

[Stephen P. Morse]

If I'm reading this diff correctly, you are removing the wrong thing.  The item
to be removed is not the string specifying the server for the wallet tables.
Rather it is the checkbox for enabling prefilling of forms that should be
removed.

Also, it would be easier to code-review if you did a contect diff instead (i.e.,
use the -c options).

Comment 7

[matt]

This was the diff i meant to give

C:\mozilla\xpfe\components\prefwindow\resources\content>cvs diff -c pref-advance
d.xul
Index: pref-advanced.xul
===================================================================
RCS file: /cvsroot/mozilla/xpfe/components/prefwindow/resources/content/pref-adv
anced.xul,v
retrieving revision 1.14
diff -c -r1.14 pref-advanced.xul
*** pref-advanced.xul   1999/10/01 20:48:52     1.14
--- pref-advanced.xul   1999/10/27 01:12:32
***************
*** 86,98 ****
                                        &remSignCheck.label;
                                </html:label>
                        </html:div>
-                       <html:div>
-                       <html:input type="checkbox" checked="true" id="pref:0:bo
ol:wallet.captureForms" />
-                               <html:label for="pref:0:bool:wallet.captureForms
" accesskey="c" tabindex="0">
-                                       &capFormsCheck.label;
-                               </html:label>
-                       </html:div>
-

        </html:fieldset>
        </box>
--- 86,91 ----

Comment 8

[Stephen P. Morse]

That looks better.  Consider it reviewed.

Comment 9

[matt]

fixed

Comment 10

[Paul MacQuiddy]

veriifed, this is gone now