Closed
Bug 1516915
Opened 5 years ago
Closed 5 years ago
GetBuildConfiguration in TestingFunctions.cpp should support arm7 detection.
Categories
(Core :: JavaScript Engine, enhancement, P2)
Tracking
()
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: bc, Assigned: lth)
References
Details
Attachments
(2 files)
1011 bytes,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
4.52 KB,
patch
|
lth
:
review+
|
Details | Diff | Splinter Review |
GetBuildConfiguration in https://searchfox.org/mozilla-central/source/js/src/builtin/TestingFunctions.cpp#123 supports detecting 'arm64' but not 'arm7' which leads to the need to kludge the testing for 'arm7'. If 'arm7' was available along with 'arm64' instead of using skip-if: !getBuildConfiguration()['x86'] && !getBuildConfiguration()['x64'] we could use skip-if: getBuildConfiguration()['arm7'] || getBuildConfiguration()['arm64'] Bonus points if 'arm' was supported which would be true for either 'arm7' or 'arm64'.
Assignee | ||
Comment 1•5 years ago
|
||
Having an alias for two different architectures sounds like a bit of a footgun to me. In what situations do you see a use for this?
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → lhansen
Status: NEW → ASSIGNED
Priority: -- → P2
Hardware: Unspecified → ARM
Assignee | ||
Comment 2•5 years ago
|
||
This just follows the existing pattern we use for ARM64: if "arm" is set the JIT generates code for ARM; if "arm-simulator" is not set then we're additionally running on real hardware.
Attachment #9033924 -
Flags: review?(jdemooij)
Reporter | ||
Comment 3•5 years ago
|
||
arm meaning just arm-32 would be sufficient for me. As for the use-case of arm7, arm64 and arm as an alias for either it would just simplify the skip-if conditions for tests which should be skipped for either and is not a requirement.
Comment 4•5 years ago
|
||
Comment on attachment 9033924 [details] [diff] [review] bug1516915-recognize-arm-in-build-configuration.patch Review of attachment 9033924 [details] [diff] [review]: ----------------------------------------------------------------- I assume you want to use this here and in other files? https://searchfox.org/mozilla-central/source/js/src/jit-test/tests/wasm/spec/float_memory.wast.js#1
Attachment #9033924 -
Flags: review?(jdemooij) → review+
Comment 5•5 years ago
|
||
Thanks for the patch! (In reply to Bob Clary [:bc:] from comment #0) > skip-if: !getBuildConfiguration()['x86'] && !getBuildConfiguration()['x64'] I will suggest that we stay away from such negations in skip-if conditions as they are not easily grep-able.
Reporter | ||
Comment 6•5 years ago
|
||
I plan to replace those with the arm-32 specific condition when it is available.
Reporter | ||
Comment 7•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&group_state=expanded&revision=820d5867522508b5ea0f4817e4c4fe4a7a7b952a&selectedJob=219736872 lth: If this passes review, would you please land it with your patch?
Attachment #9034124 -
Flags: review?(lhansen)
Assignee | ||
Comment 8•5 years ago
|
||
Comment on attachment 9034124 [details] [diff] [review] bug-1516915-skip-if-arm.patch Review of attachment 9034124 [details] [diff] [review]: ----------------------------------------------------------------- Sure thing.
Attachment #9034124 -
Flags: review?(lhansen) → review+
Pushed by lhansen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f391e2edd0f9 Add 'arm' (ie ARM-32 codegen) to the build configuration object. r=jandem https://hg.mozilla.org/integration/mozilla-inbound/rev/44ac43e4e56f Use new 'arm' property of the build configuration object in jit-test skip-if conditions, r=lth
Comment 10•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f391e2edd0f9 https://hg.mozilla.org/mozilla-central/rev/44ac43e4e56f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•