Closed
Bug 1516957
Opened 5 years ago
Closed 5 years ago
Remove uses of ContentTask from the new "about:config" tests
Categories
(Toolkit :: Preferences, enhancement, P1)
Toolkit
Preferences
Tracking
()
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: Paolo, Assigned: Paolo)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
After discussing with Brian in bug 1510162, we've decided to remove the uses of ContentTask from the tests of the new "about:config" page, because the page will continue to be loaded in the parent process for the time being. While the Fission project will separate content processes for each origin, giving the theoretical ability to differentiate the process type for privileged browser pages and regular web content, in the initial release of Fission all the content processes will be of the same type, and have access to the same cross-process APIs. This means that if we implemented generic write access to preferences, processes running unprivileged pages would have the same access, increasing the attack surface that could allow an exploit to escape the sandbox. Removing ContentTask usage will make it easier to refactor tests so that they share more code.
Assignee | ||
Comment 1•5 years ago
|
||
Uses of ContentTask can be removed because the page will continue to be loaded in the parent process for the time being. We don't want to give generic write access to preferences to the content processes until there is a way to separate privileged browser pages from regular web content using different process types.
Assignee | ||
Comment 2•5 years ago
|
||
Depends on D15513
Assignee | ||
Comment 3•5 years ago
|
||
This results in querying the document more often, but makes the test code more concise. Depends on D15514
Assignee | ||
Comment 4•5 years ago
|
||
Depends on D15515
Assignee | ||
Comment 5•5 years ago
|
||
There is more refactoring that can be done in tests, for example creating more specific accessors for various button types, but I think we can work on it along with other bugs, instead of doing everything in advance here.
Assignee | ||
Comment 6•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e5bcc7485e5649461d3c5d62cc07c49a2538616
Pushed by paolo.mozmail@amadzone.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/c762e770dec4 Part 1 - Remove uses of ContentTask from the new "about:config" tests. r=bgrins https://hg.mozilla.org/integration/mozilla-inbound/rev/214d0e9f7825 Part 2 - Create a base test class and unify tab creation functions. r=bgrins https://hg.mozilla.org/integration/mozilla-inbound/rev/dda920bc62dd Part 3 - Share more test functions. r=bgrins https://hg.mozilla.org/integration/mozilla-inbound/rev/c1a87fe81d16 Part 4 - Share the search function. r=bgrins
Comment 8•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c762e770dec4 https://hg.mozilla.org/mozilla-central/rev/214d0e9f7825 https://hg.mozilla.org/mozilla-central/rev/dda920bc62dd https://hg.mozilla.org/mozilla-central/rev/c1a87fe81d16
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•