1516977 - 2.71 - 3.1% compiler_metrics num_static_constructors (windows2012-aarch64) regression on push 371ce9714a3e21fa4f2550d264626858ad7b1e48 (Thu Dec 20 2018)

Status: RESOLVED WORKSFORME

(Testing :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

We have detected a build metrics regression from push:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=371ce9714a3e21fa4f2550d264626858ad7b1e48

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

  3%  compiler_metrics num_static_constructors windows2012-aarch64 opt msvc-aarch64       613.00 -> 632.00
  3%  compiler_metrics num_static_constructors windows2012-aarch64 debug msvc-aarch64     958.00 -> 984.00


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=18382

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

:froydnj- can you comment on what should be done with a static constructor increase?

Comment 2

[(Away)]

IMO this is a wontfix. The offending patches were filling in a missing feature (webrtc) that had been temporarily disabled on arm64 in order to get builds stood up faster. Whatever constructors appeared when we enabled webrtc are constructors that we've been shipping on intel builds for ages.

Comment 3

[Nathan Froyd [:froydnj]]

dmajor is correct.