Closed Bug 1516983 Opened 3 years ago Closed 3 years ago

Crash in CDevice::GetImmediateContext3 caused by FRAPS

Categories

(External Software Affecting Firefox :: Other, defect)

Product:
External Software Affecting Firefox
Component:
Other
Platform:
Unspecified
Windows 10
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(firefox66 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: gsvelto, Assigned: gsvelto)

References

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

Bug 1516983 - Add the FRAPS .dll to the blocklist
47 bytes, text/x-phabricator-request
Details | Review 
This bug was filed from the Socorro interface and is
report bp-edbf07bf-72d4-4f26-b371-8fdb30181230.
=============================================================

Top 5 frames of crashing thread:

0  @0x292e9c3d9a0 
1 d3d11.dll CDevice::GetImmediateContext3 
2 fraps64.dll fraps64.dll@0xf482 
3 fraps64.dll fraps64.dll@0x273c7 
4 d3d11.dll CContext::TID3D11DeviceContext_UpdateSubresource_<4> 

=============================================================

I noticed this and other similar crashes all with an entry for fraps64.dll on the stack. FRAPS was a popular videogame recorder/fps overlay software but it hasn't been developed in years. I suggest we simply block this DLL to prevent users that still have it installed from experiencing crashes.
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Crash Signature: [@ CDevice::GetImmediateContext3] → [@ CDevice::GetImmediateContext3] [@ CDevice::GetImmediateContext1] [@ CDevice::GetImmediateContext]
status-firefox66: --- → affected

Do we know the injection mechanism that FRAPS uses? Or have we tested this?

I just want to make sure that the block doesn't have adverse effects: that happens sometimes.

Flags: needinfo?(gsvelto)

(In reply to Aaron Klotz [:aklotz] from comment #2)

Do we know the injection mechanism that FRAPS uses? Or have we tested this?

I just want to make sure that the block doesn't have adverse effects: that happens sometimes.

I don't know what mechanism it uses but I can test it and report back, leaving the NI? for now.

It seems that FRAPS uses SetWindowsHookEx() to inject his DLL into other processes. I tried installing FRAPS then crashing my local build both w/ and w/o the entry in the DLL blocklist. When the entry is present I cannot find the fraps64.dll module in the crash report so it must have been blocked. I don't know if there may be other adverse effects.

Flags: needinfo?(gsvelto)
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ac8281636fba
Add the FRAPS .dll to the blocklist r=aklotz

https://hg.mozilla.org/mozilla-central/rev/ac8281636fba

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox66: affected → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.