1517039 - hixie-004.xml SVG test has 2-4x perf regression with WebRender enabled

Status: RESOLVED WORKSFORME

(Core :: Graphics: WebRender, defect, P2)

Description

[Chris Peterson [:cpeterson]]

STR:
1. Enable gfx.webrender.all
2. Run https://bugzilla.mozilla.org/attachment.cgi?id=9033648

RESULT:
On my Windows 10 laptop, the hixie-004.xml test takes about:

* 8 seconds with WebRender disabled
* 18 seconds with WebRender enabled before WR bug 1512730 landed
* 30 seconds with WebRender enabled after WR bug 1512730 landed

I bisected this regression to WR bug 1512730. This bug might be related to tsvg regression bug 1513521, but it is not a dupe because the hixie-004.xml test was already 2x slower with WebRender enabled before WR bug 1512730 landed.

Comment 1

[Jim Mathies [:jimm]]

Hey Jeff, curious, are we not blocking on svg regressions? Some concern here in that we use svg pretty heavily in front end ui. (Maybe that isn't impacted by webrender changes?)

Comment 2

[Jeff Muizelaar [:jrmuizel]]

This was a webrender only regression in svg. It likely corresponds to bug 1513521 which should be fixed by bug 1518773.

Comment 3

[Pascal Chevrel:pascalc (PTO until April 26)]

Chris, is that still an issue now that bug 1518773 is fixed?

Comment 4

[Chris Peterson [:cpeterson]]

I can still reproduce this bug.

Running the https://bugzilla.mozilla.org/attachment.cgi?id=9033648 test case on my Dell XPS 13 Windows laptop:

Firefox 65 without WebRender = 9 seconds
Firefox 67 Nightly without WebRender = 9 seconds
Firefox 67 Nightly with WebRender = 25 seconds :(
Chrome 73 = 8 seconds
Edge 18 = 8 seconds

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Jeff, it seems that this is a different WR regression than previously thought, since this is a p2, can this be reevaluated wrt to the 67 release? Thanks

Comment 6

[Mayank Bansal]

(In reply to Chris Peterson [:cpeterson] from comment #4)

I can still reproduce this bug.

Running the https://bugzilla.mozilla.org/attachment.cgi?id=9033648 test case
on my Dell XPS 13 Windows laptop:

Firefox 65 without WebRender = 9 seconds
Firefox 67 Nightly without WebRender = 9 seconds
Firefox 67 Nightly with WebRender = 25 seconds :(
Chrome 73 = 8 seconds
Edge 18 = 8 seconds

On my Win10x64 with intel graphics, I get the almost same timings with /without WR

With WR : 9.3s
Wihout WR: 8.9s

Comment 7

[Mayank Bansal]

please mark my comments as offtopic. I dont know how. i filed bug 1535596 for the issue

Comment 8

[Chris Peterson [:cpeterson]]

(In reply to Mayank Bansal from comment #6)

On my Win10x64 with intel graphics, I get the almost same timings with /without WR

With WR : 9.3s
Wihout WR: 8.9s

Interesting. Here is the graphics information from my about:support:

Graphics

Features
Compositing: WebRender
asyncPanZoom: wheel input enabled; touch input enabled; scrollbar drag enabled; keyboard enabled; autoscroll enabled
webgl1WSIInfo: EGL_VENDOR: Google Inc. (adapter LUID: 000000000000f2ae) EGL_VERSION: 1.4 (ANGLE 2.1.0.eff6bfdb1db9) EGL_EXTENSIONS: EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_ANGLE_direct_composition EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource EGL_CHROMIUM_sync_control EGL_EXT_pixel_format_float EGL_KHR_surfaceless_context EGL_ANGLE_display_texture_share_group EGL_ANGLE_create_context_client_arrays EGL_ANGLE_program_cache_control EGL_ANGLE_robust_resource_initialization EGL_ANGLE_create_context_extensions_enabled EGL_MOZ_create_context_provoking_vertex_dont_care EGL_EXTENSIONS(nullptr): EGL_EXT_client_extensions EGL_EXT_platform_base EGL_EXT_platform_device EGL_ANGLE_platform_angle EGL_ANGLE_platform_angle_d3d EGL_ANGLE_device_creation EGL_ANGLE_device_creation_d3d11 EGL_ANGLE_experimental_present_path EGL_KHR_client_get_all_proc_addresses EGL_KHR_debug EGL_ANGLE_explicit_context
WebGL 1 Driver Renderer: Google Inc. -- ANGLE (Intel(R) UHD Graphics 630 Direct3D11 vs_5_0 ps_5_0)
WebGL 1 Driver Version: OpenGL ES 2.0 (ANGLE 2.1.0.eff6bfdb1db9)
WebGL 1 Driver Extensions: GL_ANGLE_client_arrays GL_ANGLE_depth_texture GL_ANGLE_explicit_context GL_ANGLE_explicit_context_gles1 GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_pack_reverse_row_order GL_ANGLE_program_cache_control GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_color_buffer_float_rgb GL_CHROMIUM_color_buffer_float_rgba GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_minmax GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_frag_depth GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_s3tc_srgb GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_KHR_parallel_shader_compile GL_KHR_robust_buffer_access_behavior GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_surfaceless_context GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object OES_compressed_EAC_R11_signed_texture OES_compressed_EAC_R11_unsigned_texture OES_compressed_EAC_RG11_signed_texture OES_compressed_EAC_RG11_unsigned_texture OES_compressed_ETC2_RGB8_texture OES_compressed_ETC2_RGBA8_texture OES_compressed_ETC2_punchthroughA_RGBA8_texture OES_compressed_ETC2_punchthroughA_sRGB8_alpha_texture OES_compressed_ETC2_sRGB8_alpha8_texture OES_compressed_ETC2_sRGB8_texture
WebGL 1 Extensions: ANGLE_instanced_arrays EXT_blend_minmax EXT_color_buffer_half_float EXT_disjoint_timer_query EXT_frag_depth EXT_shader_texture_lod EXT_sRGB EXT_texture_filter_anisotropic OES_element_index_uint OES_standard_derivatives OES_texture_float OES_texture_float_linear OES_texture_half_float OES_texture_half_float_linear OES_vertex_array_object WEBGL_color_buffer_float WEBGL_compressed_texture_s3tc WEBGL_compressed_texture_s3tc_srgb WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_depth_texture WEBGL_draw_buffers WEBGL_lose_context
WebGL 2 Driver WSI Info: EGL_VENDOR: Google Inc. (adapter LUID: 000000000000f2ae) EGL_VERSION: 1.4 (ANGLE 2.1.0.eff6bfdb1db9) EGL_EXTENSIONS: EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_ANGLE_direct_composition EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource EGL_CHROMIUM_sync_control EGL_EXT_pixel_format_float EGL_KHR_surfaceless_context EGL_ANGLE_display_texture_share_group EGL_ANGLE_create_context_client_arrays EGL_ANGLE_program_cache_control EGL_ANGLE_robust_resource_initialization EGL_ANGLE_create_context_extensions_enabled EGL_MOZ_create_context_provoking_vertex_dont_care EGL_EXTENSIONS(nullptr): EGL_EXT_client_extensions EGL_EXT_platform_base EGL_EXT_platform_device EGL_ANGLE_platform_angle EGL_ANGLE_platform_angle_d3d EGL_ANGLE_device_creation EGL_ANGLE_device_creation_d3d11 EGL_ANGLE_experimental_present_path EGL_KHR_client_get_all_proc_addresses EGL_KHR_debug EGL_ANGLE_explicit_context
WebGL 2 Driver Renderer: Google Inc. -- ANGLE (Intel(R) UHD Graphics 630 Direct3D11 vs_5_0 ps_5_0)
WebGL 2 Driver Version: OpenGL ES 3.0 (ANGLE 2.1.0.eff6bfdb1db9)
WebGL 2 Driver Extensions: GL_ANGLE_client_arrays GL_ANGLE_depth_texture GL_ANGLE_explicit_context GL_ANGLE_explicit_context_gles1 GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_multiview GL_ANGLE_pack_reverse_row_order GL_ANGLE_program_cache_control GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_color_buffer_float_rgb GL_CHROMIUM_color_buffer_float_rgba GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_minmax GL_EXT_color_buffer_float GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_frag_depth GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_s3tc_srgb GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_norm16 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_KHR_parallel_shader_compile GL_KHR_robust_buffer_access_behavior GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_EGL_image_external_essl3 GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_surfaceless_context GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object OES_compressed_EAC_R11_signed_texture OES_compressed_EAC_R11_unsigned_texture OES_compressed_EAC_RG11_signed_texture OES_compressed_EAC_RG11_unsigned_texture OES_compressed_ETC2_RGB8_texture OES_compressed_ETC2_RGBA8_texture OES_compressed_ETC2_punchthroughA_RGBA8_texture OES_compressed_ETC2_punchthroughA_sRGB8_alpha_texture OES_compressed_ETC2_sRGB8_alpha8_texture OES_compressed_ETC2_sRGB8_texture
WebGL 2 Extensions: EXT_color_buffer_float EXT_disjoint_timer_query EXT_texture_filter_anisotropic OES_texture_float_linear WEBGL_compressed_texture_s3tc WEBGL_compressed_texture_s3tc_srgb WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_lose_context
Direct2D: true
Uses Tiling (Content): true
Off Main Thread Painting Enabled: true
Off Main Thread Painting Worker Count: 4
Target Frame Rate: 60
DirectWrite: true (10.0.18351.1)
GPU #1
Active: Yes
Description: Intel(R) UHD Graphics 630
Vendor ID: 0x8086
Device ID: 0x3e9b
Driver Version: 25.20.100.6471
Driver Date: 12-10-2018
Drivers: igdumdim64 igd10iumd64 igd10iumd64 igd12umd64 igdumdim32 igd10iumd32 igd10iumd32 igd12umd32
Subsys ID: 087c1028
RAM: Unknown
GPU #2
Active: No
Description: NVIDIA GeForce GTX 1050 Ti with Max-Q Design
Vendor ID: 0x10de
Device ID: 0x1c8c
Driver Version: 24.21.13.9793
Driver Date: 5-22-2018
Drivers: C:\WINDOWS\System32\DriverStore\FileRepository\nvdm.inf_amd64_786f30519164c09a\nvldumdx.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nvdm.inf_amd64_786f30519164c09a\nvldumdx.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nvdm.inf_amd64_786f30519164c09a\nvldumdx.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nvdm.inf_amd64_786f30519164c09a\nvldumdx.dll C:\WINDOWS\System32\DriverStore\FileRepository\nvdm.inf_amd64_786f30519164c09a\nvldumd.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nvdm.inf_amd64_786f30519164c09a\nvldumd.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nvdm.inf_amd64_786f30519164c09a\nvldumd.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nvdm.inf_amd64_786f30519164c09a\nvldumd.dll
Subsys ID: 087c1028
RAM: 4096
Diagnostics
AzureCanvasBackend: direct2d 1.1
AzureCanvasBackend (UI Process): skia
AzureContentBackend: skia
AzureContentBackend (UI Process): skia
AzureFallbackCanvasBackend (UI Process): cairo
Slow Frame #01: Frame 136(https://s3.amazonaws.com/lists.disconnect.me/simple_ad.txt) CONTENT_FRAME_TIME 7131144 - Transaction start 0.000000, main-thread time 7.271200, full paint time 10.883900, Skipped composites 0, Composite start 16.115800, Resource upload time 0.328000, GPU cache upload time 0.177000, Render time 2.865900, Composite time 5.499800
Slow Frame #02: Frame 6(https://news.ycombinator.com/item?id=19401885) CONTENT_FRAME_TIME 2289866 - Transaction start 0.000000, main-thread time 22.003800, full paint time 24.159700, Skipped composites 0, Composite start 24.801000, Resource upload time 0.001100, GPU cache upload time 0.559600, Render time 5.442900, Composite time 10.202400
Slow Frame #03: Frame 13(https://news.ycombinator.com/item?id=19401885) CONTENT_FRAME_TIME 1599387 - Transaction start 0.000000, main-thread time 24.192500, full paint time 27.405100, Skipped composites 0, Composite start 27.990600, Resource upload time 0.001000, GPU cache upload time 0.498800, Render time 5.350200, Composite time 8.708200
Slow Frame #04: Frame 4(https://bittersoutherner.com/waffle-house-vistas) CONTENT_FRAME_TIME 1591062 - Transaction start 0.000000, main-thread time 10.923200, full paint time 15.636000, Skipped composites 0, Composite start 22.163200, Resource upload time 0.000600, GPU cache upload time 0.342300, Render time 4.756300, Composite time 8.449700
Slow Frame #05: Frame 138(https://wiki.mozilla.org/Mobile/GeckoView/Bugs) CONTENT_FRAME_TIME 1587880 - Transaction start 0.000000, main-thread time 14.738300, full paint time 25.306200, Skipped composites 0, Composite start 32.618200, Resource upload time 0.000900, GPU cache upload time 0.276200, Render time 5.499800, Composite time 10.128800
Slow Frame #06: Frame 71(https://s3.amazonaws.com/lists.disconnect.me/simple_ad.txt) CONTENT_FRAME_TIME 1564852 - Transaction start 0.000000, main-thread time 3.899700, full paint time 5.803700, Skipped composites 0, Composite start 6.095200, Resource upload time 0.000600, GPU cache upload time 0.134600, Render time 2.978100, Composite time 5.722900
Slow Frame #07: Frame 273(https://easylist.to/) CONTENT_FRAME_TIME 1146140 - Transaction start 0.000000, main-thread time 5.016100, full paint time 7.625700, Skipped composites 0, Composite start 23.690800, Resource upload time 0.000500, GPU cache upload time 0.168400, Render time 2.045900, Composite time 5.488000
Slow Frame #08: Frame 15(https://news.ycombinator.com/item?id=19401705) CONTENT_FRAME_TIME 1078192 - Transaction start 0.000000, main-thread time 25.862700, full paint time 29.838400, Skipped composites 0, Composite start 31.161800, Resource upload time 0.000800, GPU cache upload time 0.284400, Render time 4.915400, Composite time 8.217100
Slow Frame #09: Frame 135(https://wiki.mozilla.org/Mobile/GeckoView/Bugs) CONTENT_FRAME_TIME 949773 - Transaction start 0.000000, main-thread time 16.336700, full paint time 20.142800, Skipped composites 0, Composite start 34.373300, Resource upload time 0.000700, GPU cache upload time 0.285200, Render time 6.027100, Composite time 9.806900
Slow Frame #10: Frame 14(https://news.ycombinator.com/item?id=19402844) CONTENT_FRAME_TIME 947460 - Transaction start 0.000000, main-thread time 21.779500, full paint time 27.100700, Skipped composites 0, Composite start 39.106600, Resource upload time 0.000800, GPU cache upload time 0.339500, Render time 5.008400, Composite time 8.370200
GPUProcessPid: 11492
GPUProcess: Terminate GPU Process
Device Reset: Trigger Device Reset
ClearType Parameters: Gamma: 1.8 Pixel Structure: RGB ClearType Level: 100 Enhanced Contrast: 50
Decision Log
WEBRENDER:
opt-in by default: WebRender is an opt-in feature
available by user: Force enabled by pref
WEBRENDER_QUALIFIED:
blocked by env: Has battery

Comment 9

[Chris Peterson [:cpeterson]]

With WebRender, the test takes 25 seconds when my laptop is on battery power but only 12-14 seconds when plugged into AC power. However, my about:support says that my builtin GPU #1 (Intel UHD Graphics 630) is active in both scenarios, not my discrete GPU #2 (NVIDIA GeForce GTX 1050 Ti).

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

This is P2 and assigned, so I'm removing it from weekly regression triage by marking it fix-optional.
Happy to take a patch for 70 or in future.

Comment 11

[Nicolas Silva [:nical]]

This got better. 15 seconds with webrender 13 seconds without. Probably thanks to the blob recent-ish blob image recoordination changes.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last months and this bug has priority 'P2'.
:gw, could you have a look please?
For more information, please visit auto_nag documentation.