Closed
Bug 1517044
Opened 6 years ago
Closed 6 years ago
It is possible to write over nsIUpdate and nsIUpdatePatch readonly attributes using setProperty since they also implement nsIWritablePropertyBag
Categories
(Toolkit :: Application Update, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
Attachments
(1 file, 1 obsolete file)
|
12.27 KB,
patch
|
molly
:
review+
|
Details | Diff | Splinter Review |
I noticed this while working on bug 1516899.
|
Assignee | |
Comment 1•6 years ago
|
||
This is mainly for correctness and that it bothers me that the attributes (especially the read only attributes) can be over written by nsIWritablePropertyBag.
|
|
Assignee | |
Comment 2•6 years ago
|
||
Comment on attachment 9035444 [details] [diff] [review]
patch rev1
Pushed to try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=62f45e6e2419d3af0fd56c650f97889b3b4c3865
|
|
Assignee | |
Updated•6 years ago
|
Attachment #9035444 -
Flags: review?(mhowell)
|
|
Assignee | |
Comment 3•6 years ago
|
||
Added another check to the constructors for safety
Attachment #9035444 -
Attachment is obsolete: true
Attachment #9035444 -
Flags: review?(mhowell)
Attachment #9035525 -
Flags: review?(mhowell)
|
||
Updated•6 years ago
|
Attachment #9035525 -
Flags: review?(mhowell) → review+
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/df91f6e79753
Don't allow nsIWritablePropertyBag calls to overwrite nsIUpdate and nsIUpdatePatch attributes. r=mhowell
|
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•