Bug 1517055 (angle-66)

ANGLE texture upload fails due to division by zero when the texture's width or height is 1

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P3
normal
RESOLVED FIXED
6 months ago
Last month

People

(Reporter: bholley, Assigned: jgilbert)

Tracking

(Regressed 1 bug)

unspecified
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(2 attachments)

Reporter

Description

6 months ago
See https://bugs.chromium.org/p/angleproject/issues/detail?id=3039

This bit me when I tried to reduce the size of VertexDataTextures in bug 1505449, since the needed size is often 1 when running under wrench. I added a simple workaround for the VertexDataTexture (just forcing the minimum height to 2), but I'm filing a separate bug because I'm not sure if this will affect us in other ways.

My primary concern was that we could end up with a 1x600 standalone texture for an image, and texture upload would fail. But I tested locally and that doesn't seem to happen, so whatever texture upload path we take for images must bypass this.
Reporter

Comment 1

6 months ago
Dzmitry, can you think of any other cases in WR where this might be a problem?
Flags: needinfo?(dmalyshau)
Reporter

Comment 2

6 months ago
Jeff will work to get this fixed on the ANGLE side. Thanks Jeff!
Assignee: nobody → jgilbert

Here are potential spots in WR:

  • multiple spots in "gpu_glyph_renderer.rs
  • dummy_cache_texture initialization
  • any image being allocated via allocate_standalone_entry
Flags: needinfo?(dmalyshau)
Reporter

Comment 4

5 months ago

Jeff, is this something we can have fixed in ANGLE and revendored within the next ~6 weeks, or should we work around it for now?

Flags: needinfo?(jgilbert)
Priority: -- → P3
Assignee

Comment 5

5 months ago

We'll have this fixed in 66, yes.

Flags: needinfo?(jgilbert)
Reporter

Updated

5 months ago
Depends on: angle-68
Assignee

Updated

5 months ago
No longer depends on: angle-68

Comment 8

5 months ago
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c488b723dc7
Update update-angle.py for newer ANGLE changes. r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/9474df714baf
Revendor ANGLE mozilla/firefox-66. (1xN texture cherry-pick) r=bholley
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Assignee

Updated

2 months ago
Alias: angle-66
Assignee

Updated

Last month
Regressions: 1550655
You need to log in before you can comment on or make changes to this bug.