Closed Bug 1517162 Opened 2 years ago Closed 2 years ago
Provide a messenger
.* global as an alias
There is chrome.*, browser.*, I think it would make sense for us to have a mail.* global for our APIs, or something similar. I recall that there was a way to make APIs only work on some of the globals, i.e. there was a Firefox API that worked on browser.* but not on chrome.*. This may have been the menus API. We could consider allowing all our mail specific APIs on mail.* and anything that is shared with Firefox we can leave on browser.*/chrome.*.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #9060029 - Flags: review?(geoff)
Comment on attachment 9060061 [details] [diff] [review] Fix - v2 Review of attachment 9060061 [details] [diff] [review]: ----------------------------------------------------------------- I think this is okay from a code point of view, but I'd like to have someone more familiar with the toolkit code look over it. My other concern is that if somehow the monkey-patching is broken and we're unable to fix it (e.g. if the importing semantics change or the objects you're modifying get frozen), what happens to all the extensions that that used the mail object? I know it's unlikely but I've seen a lot of unlikely things happen in the last year. ::: mail/components/extensions/parent/ext-mail.js @@ +53,5 @@ > + > + return initExtensionContext.apply(ExtensionContent, arguments); > + }; > + > + // This patches priviledged pages such as the background script privileged While we're here, shouldn't these comment sentences have a full stop?
Attachment #9060061 - Flags: review?(geoff) → review+
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 70.0
Comment on attachment 9084624 [details] [diff] [review] Fix - v3 Getting this into Thunderbird 68 would be great for add-on authors.
Comment on attachment 9084624 [details] [diff] [review] Fix - v3 No need for beta since it is already in TB 70 (beta). I'd have shipped it in TB 68.1 had the request come earlier ;-)
Summary: Provide a mail.* global as an alias → Provide a messenger.* global as an alias
You need to log in before you can comment on or make changes to this bug.