Android tests may report remote test log twice

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P1
normal
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: gbrown, Assigned: gbrown)

Tracking

(Blocks 1 bug)

unspecified
Firefox 66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 months ago
As seen in https://bugzilla.mozilla.org/show_bug.cgi?id=1392946#c21, sometimes when things go wrong during an Android test run, the remote test log is dumped twice. That's confusing, and avoidable.

Comment 3

5 months ago
Comment on attachment 9033948 [details] [diff] [review]
ensure remote log deleted before launching test app

Review of attachment 9033948 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a little concerned that we might be deleting the contents of the log prior to running the app, but looking at the code where this is called, it seems that runApp is more about starting the framework which would make this ok.

r+
Attachment #9033948 - Flags: review?(bob) → review+
(Assignee)

Comment 4

5 months ago
I think all runApp clients use runApp to start the browser + generate the remote log + collect and report the remote log, so any remote log present at the start of runApp should have already been reported. If that hadn't happened somehow, it would be confusing; I'll add a "runApp deleted remote log" info log just in case.

Comment 5

5 months ago
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba0acece312a
Ensure Android remote test log is deleted before launching test app; r=bc
(Assignee)

Updated

5 months ago
Priority: -- → P1

Comment 6

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ba0acece312a
Status: NEW → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.