Closed
Bug 1517169
Opened 2 years ago
Closed 2 years ago
Android tests may report remote test log twice
Categories
(Firefox for Android Graveyard :: Testing, enhancement, P1)
Firefox for Android Graveyard
Testing
Tracking
(firefox66 fixed)
RESOLVED
FIXED
Firefox 66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: gbrown, Assigned: gbrown)
References
Details
Attachments
(1 file)
687 bytes,
patch
|
bc
:
review+
|
Details | Diff | Splinter Review |
As seen in https://bugzilla.mozilla.org/show_bug.cgi?id=1392946#c21, sometimes when things go wrong during an Android test run, the remote test log is dumped twice. That's confusing, and avoidable.
![]() |
Assignee | |
Comment 1•2 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=9ebc58925729e4003bf1c5050fa67f88900560bf
![]() |
Assignee | |
Comment 2•2 years ago
|
||
Attachment #9033948 -
Flags: review?(bob)
Comment 3•2 years ago
|
||
Comment on attachment 9033948 [details] [diff] [review] ensure remote log deleted before launching test app Review of attachment 9033948 [details] [diff] [review]: ----------------------------------------------------------------- I'm a little concerned that we might be deleting the contents of the log prior to running the app, but looking at the code where this is called, it seems that runApp is more about starting the framework which would make this ok. r+
Attachment #9033948 -
Flags: review?(bob) → review+
![]() |
Assignee | |
Comment 4•2 years ago
|
||
I think all runApp clients use runApp to start the browser + generate the remote log + collect and report the remote log, so any remote log present at the start of runApp should have already been reported. If that hadn't happened somehow, it would be confusing; I'll add a "runApp deleted remote log" info log just in case.
Pushed by gbrown@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ba0acece312a Ensure Android remote test log is deleted before launching test app; r=bc
![]() |
Assignee | |
Updated•2 years ago
|
Priority: -- → P1
Comment 6•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ba0acece312a
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Updated•3 months ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•