1517169 - Android tests may report remote test log twice

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, enhancement, P1)

Description

[Geoff Brown [:gbrown]]

As seen in https://bugzilla.mozilla.org/show_bug.cgi?id=1392946#c21, sometimes when things go wrong during an Android test run, the remote test log is dumped twice. That's confusing, and avoidable.

Comment 1

[Geoff Brown [:gbrown]]

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=9ebc58925729e4003bf1c5050fa67f88900560bf

Comment 2

[Geoff Brown [:gbrown]]

Attachment: ensure remote log deleted before launching test app

Comment 3

[Bob Clary [:bc] (inactive)]

Comment on attachment 9033948 [details] [diff] [review]
ensure remote log deleted before launching test app

Review of attachment 9033948 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a little concerned that we might be deleting the contents of the log prior to running the app, but looking at the code where this is called, it seems that runApp is more about starting the framework which would make this ok.

r+

Comment 4

[Geoff Brown [:gbrown]]

I think all runApp clients use runApp to start the browser + generate the remote log + collect and report the remote log, so any remote log present at the start of runApp should have already been reported. If that hadn't happened somehow, it would be confusing; I'll add a "runApp deleted remote log" info log just in case.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba0acece312a
Ensure Android remote test log is deleted before launching test app; r=bc

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ba0acece312a