Closed Bug 1517178 Opened 5 years ago Closed 5 years ago

[raptor] disable adb verbose output during logcat collection

Categories

(Testing :: Raptor, defect, P5)

Product:
Testing
Component:
Raptor
Type:
defect

Tracking

(firefox67 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: CosminS, Assigned: bc)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, Whiteboard: [cia:logs:2019])

Attachments

(1 file)

bug-1517178-logcat.patch
1.38 KB, patch
rwood
: review+
Details | Diff | Splinter Review 
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=219534552&repo=autoland&lineNumber=262

Th push: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=fda9de78ff7f1836278a7bd4b2581940883afb84&searchStr=mda&selectedJob=219534552

tcp        0      0 localhost:5037          localhost:36573         TIME_WAIT   -                timewait (56.31/0/0)
tcp        0      0 localhost:5037          localhost:60089         TIME_WAIT   -                timewait (56.21/0/0)
tcp        0      0 localhost:5037          localhost:57213         TIME_WAIT   -                timewait (56.00/0/0)
tcp        0      0 bitbar-ubuntu-205:45706 ec2-34-210-240-14:https ESTABLISHED 1/taskcluster-worke off (0.00/0/0)
tcp        0      0 localhost:5037          localhost:58167         TIME_WAIT   -                timewait (56.00/0/0)
tcp        0      0 localhost:5037          localhost:33563         TIME_WAIT   -                timewait (54.98/0/0)
udp        0      0 127.0.0.11:44999        *:*                                 -                off (0.00/0/0)
Active UNIX domain sockets (servers and established)
Proto RefCnt Flags       Type       State         I-Node   PID/Program name    Path
payload.py exitcode 2
This doesn't seem like an Audio/Video issue to me. I couldn't even find payload.py on searchfox.

Cosmin, could you double check the component here? Thanks!
Flags: needinfo?(csabou)
Component: Audio/Video → Testing
Flags: needinfo?(csabou)
Product: Core → Firefox for Android
Priority: -- → P5

CosminS: that latest failure is:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=223503444&repo=autoland&lineNumber=31872

INFO - raptor-main TEST-UNEXPECTED-FAIL: test 'raptor-tp6m-amazon-geckoview' timed out loading test page: https://www.amazon.com

Unfortunately the log spam from facebook prevented that message from appearing in the bug suggestions.

Whiteboard: [cia:logs:2019]

Bob, thanks for the info. Will re-star the failures, there are a bunch of them in the last couple of hours. Was wondering how come they show up on raptor tests.

Summary: Intermittent Android Task finished with payload.py exitcode 2/exitcode 1 → Intermittent Android Task finished with payload.py exitcode 2

rwood: Do you think you can do something about the log spam from facebook?

Flags: needinfo?(rwood)

(In reply to Bob Clary [:bc:] from comment #6)

rwood: Do you think you can do something about the log spam from facebook?

Any error messages that come from Firefox including JS errors we let it filter through to the terminal/log. Not sure it's a good idea to stop those - as we could miss relevant errors when there are legit problems with loading pages etc.?

Flags: needinfo?(rwood)

This stuff is already in the logcat artifact so you have a separate record of it. Perhaps not including the logcat in the normal log? Take a look at Treeherder for one of these jobs and the failure summary and consider what the sheriffs are supposed to do with those suggested failures.

(In reply to Bob Clary [:bc:] from comment #9)

This stuff is already in the logcat artifact so you have a separate record of it. Perhaps not including the logcat in the normal log? Take a look at Treeherder for one of these jobs and the failure summary and consider what the sheriffs are supposed to do with those suggested failures.

Sure, good idea - not include the logcat in the normal log. That will get rid of it for android anyway. No idea how to do that though lol, any ideas?

I'll take a look in a bit.

Flags: needinfo?(bob)

This is where we allow the 'error' messages to filter through, maybe we can just add more filters here:

https://searchfox.org/mozilla-central/rev/4faab2f1b697827b93e16cb798b22b197e5235c9/testing/raptor/raptor/outputhandler.py#37

The logcat output included in the main log is from the verbose output from adb. Temporarily turn it off when collecting logcat and reset afterwards.

Assignee: nobody → bob
Flags: needinfo?(bob)
Attachment #9040305 - Flags: review?(rwood)

The original failure reported in this bug was due to an intermittent failure to dowload test-linux.sh:

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=219534552&repo=autoland&lineNumber=132

The other errors reported here are unrelated to that error. I'm going to morph this bug to removing adb logcat spam from the log and combined with the patch in bug 1520130 we should get more actionable bugs.

Component: Testing → Raptor
Product: Firefox for Android → Testing
Summary: Intermittent Android Task finished with payload.py exitcode 2 → [raptor] disable adb verbose output during logcat collection
Version: unspecified → Trunk
Comment on attachment 9040305 [details] [diff] [review]
bug-1517178-logcat.patch

Review of attachment 9040305 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM thanks!
Attachment #9040305 - Flags: review?(rwood) → review+
Pushed by bclary@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc31e621f479
[raptor] disable adb verbose output during logcat collection, r=rwood.

https://hg.mozilla.org/mozilla-central/rev/cc31e621f479

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Blocks: 778688
See Also: → 1522286
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: