1517209 - -Wtype-limits warnings with GCC 9

Status: NEW

(Firefox Build System :: Toolchains, defect, P3)

Description

[Jan Hubicka]

Attachment: type-limits.txt

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

Comiles with GCC 9 SVN tree


Actual results:

Build failed on the  type-limits warnings



Expected results:

It should have worked :)

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Could you please provide the error messages?

Comment 2

[Chris Peterson [:cpeterson]]

There are warnings in the attached type-limits.txt log file:

obj-firefox/dom/bindings/TestCodeGenBinding.cpp:8153:17: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
| static_assert(0 <= JSJitInfo::maxSlotIndex, "We won't fit");
|               ~~^~~~~~~~~~~~~~~~~~~~~~~~~~

Looks like the bindings code generator is producing some meaningless assertions that will always be true:

static_assert(0 <= JSJitInfo::maxSlotIndex, "We won't fit");
static_assert(0 < 1, "There is no slot for us");

Comment 3

[Jan Hubicka]

Note that I discussed with GCC front-end folks to silence some of them.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88680