Status

()

defect
RESOLVED FIXED
7 months ago
6 months ago

People

(Reporter: anba, Assigned: anba)

Tracking

Trunk
mozilla66
Points:
---

Firefox Tracking Flags

(firefox-esr60 fixed, firefox65 fixed, firefox66 fixed)

Details

Attachments

(2 attachments)

2018h was released on Dec 29 2018 and two days later 2018i was issued.

tzdata2018h release notes:
- https://mm.icann.org/pipermail/tz-announce/2018-December/000053.html

tzdata2018i release notes:
- https://mm.icann.org/pipermail/tz-announce/2018-December/000054.html
Updates the tzdata files to 2018i.

(The patch applies cleanly on beta, so we don't need a separate patch file for that branch.)
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #9034388 - Flags: review?(jwalden)
Patch for ESR60 backport. (A separate patch is needed, because ESR uses ICU60, whereas Beta/Central is already using ICU63.)
Attachment #9034389 - Flags: review?(jwalden)
Attachment #9034388 - Flags: review?(jwalden) → review+
Attachment #9034389 - Flags: review?(jwalden) → review+

Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6d035ab7f93
Update tzdata in ICU data files to 2018i. r=Waldo

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66

Comment on attachment 9034388 [details] [diff] [review]
bug1517222.patch

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: N/A

User impact if declined: Wrong time zone data when calling standard Date and Intl.DateTimeFormat methods.

Based on the release notes for tzdata 2018h https://mm.icann.org/pipermail/tz-announce/2018-December/000053.html and 2018i https://mm.icann.org/pipermail/tz-announce/2018-December/000054.html, the update is of special interest for users in:

  • Qyzylorda, Kazakhstan (time zone changed from +06 to +05 on 2018-12-21)
  • Metlakatla, Alaska (observes PST this winter only)
  • Morocco (updated DST predictions around Ramadan)
  • Iran (updated DST predictions for 2038-2090)
  • São Tomé and Príncipe (time zone changed from +01 to +00 on 2019-01-01)

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce:

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): It only updates time zone data files.

String changes made/needed: None

Attachment #9034388 - Flags: approval-mozilla-beta?

Comment on attachment 9034389 [details] [diff] [review]
bug1517222-esr.patch

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: See comment #7

User impact if declined: See comment #7

Fix Landed on Version: 66

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): See comment #7

String or UUID changes made by this patch: None

Attachment #9034389 - Flags: approval-mozilla-esr60?

Comment on attachment 9034388 [details] [diff] [review]
bug1517222.patch

[Triage Comment]
Updates a number of time zones with the latest data. Approved for 65.0b10 and 60.5.0esr.

Attachment #9034388 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9034389 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.