1517240 - Remove upload_env from mozharness configs / desktop_build, set UPLOAD_PATH env in task definitions

Status: NEW

(Firefox Build System :: General, enhancement)

Description

[(not currently active) Ted Mielczarek]

I was trying out a patch in bug 1477306 but it failed because the UPLOAD_PATH directory hadn't been created early enough. I thought I had fixed that in bug 1490325:
https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/testing/mozharness/mozharness/mozilla/building/buildbase.py#1690

...but that code checks `os.environ` and `UPLOAD_PATH` isn't set in the task environment, it gets set via the mozharness `upload_env` config item:
https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/testing/mozharness/mozharness/mozilla/building/buildbase.py#868

Like:
https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/testing/mozharness/configs/builds/build_pool_specifics.py#10
https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/testing/mozharness/configs/builds/taskcluster_base_windows.py#27

We should remove that config item and just set `UPLOAD_PATH` in the task environment as is appropriate per-worker. Ideally we'd also tie the value together with the source of the value of the "public/build" artifact key, so that the env var always points to the right place.

Comment 1

[Tom Prince [:tomprince]]

This sounds like a great idea.