Closed
Bug 1517285
Opened 6 years ago
Closed 6 years ago
Contact tree in AB not dark on Mac with dark theme
Categories
(Thunderbird :: Theme, defect)
Tracking
(thunderbird65 fixed, thunderbird66 fixed)
RESOLVED
FIXED
Thunderbird 66.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(2 files, 1 obsolete file)
586.75 KB,
image/png
|
Details | |
3.00 KB,
patch
|
arshad
:
review+
jorgk-bmo
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
With the dark theme, the contacts tree in AB is still bright but the entries are hard readable.
Assignee | ||
Comment 1•6 years ago
|
||
We shouldn't use the transparency on this tree at all.
As a preparation for theming the splitters I made the splitters visually only 1px.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9033986 -
Flags: review?(arshdkhn1)
Comment 2•6 years ago
|
||
everything looks good except when any contact is clicked, you can see in the screenshot that anything is hardly visible.
Updated•6 years ago
|
Attachment #9033986 -
Flags: review?(arshdkhn1) → review-
Assignee | ||
Comment 3•6 years ago
|
||
Card display fixed.
Attachment #9033986 -
Attachment is obsolete: true
Attachment #9034369 -
Flags: review?(arshdkhn1)
Comment 4•6 years ago
|
||
Comment on attachment 9034369 [details] [diff] [review]
1517285-AB-themed-tree.patch
Review of attachment 9034369 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm. I am not sure what is the guideline for using dark and light background. How do you decide it?
Attachment #9034369 -
Flags: review?(arshdkhn1) → review+
Assignee | ||
Comment 5•6 years ago
|
||
It's depending the selected theme in Add-ons Manager. On Mac, when you use on Mac the dark theme TB, and also FX, switches to the dark theme also when the default theme is selected in Add-ons Manager.
I know there are some places, like chat, where we need some work to look correct with dark theme.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/fc3f22843429
Fix AB contact tree on Mac for dark theme by not using -moz-appearance: -moz-mac-source-list. r=arshad
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 66.0
Comment 7•6 years ago
|
||
Comment on attachment 9034369 [details] [diff] [review]
1517285-AB-themed-tree.patch
I guess this will need beta uplift, right?
Attachment #9034369 -
Flags: approval-comm-beta+
Assignee | ||
Comment 8•6 years ago
|
||
Yes.
Comment 9•6 years ago
|
||
TB 65 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/f16d6de1d4024a7b7a07eeddea307eb6aaf9e9e3
status-thunderbird65:
--- → fixed
status-thunderbird66:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•