1517285 - Contact tree in AB not dark on Mac with dark theme

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

With the dark theme, the contacts tree in AB is still bright but the entries are hard readable.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1517285-AB-themed-tree.patch

We shouldn't use the transparency on this tree at all.

As a preparation for theming the splitters I made the splitters visually only 1px.

Comment 2

[Arshad Khan [:arshad]]

Attachment: addressbook_sc.png

everything looks good except when any contact is clicked, you can see in the screenshot that anything is hardly visible.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1517285-AB-themed-tree.patch

Card display fixed.

Comment 4

[Arshad Khan [:arshad]]

Comment on attachment 9034369 [details] [diff] [review]
1517285-AB-themed-tree.patch

Review of attachment 9034369 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm. I am not sure what is the guideline for using dark and light background. How do you decide it?

Comment 5

[Richard Marti (:Paenglab)]

It's depending the selected theme in Add-ons Manager. On Mac, when you use on Mac the dark theme TB, and also FX, switches to the dark theme also when the default theme is selected in Add-ons Manager.

I know there are some places, like chat, where we need some work to look correct with dark theme.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fc3f22843429
Fix AB contact tree on Mac for dark theme by not using -moz-appearance: -moz-mac-source-list. r=arshad

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 9034369 [details] [diff] [review]
1517285-AB-themed-tree.patch

I guess this will need beta uplift, right?

Comment 8

[Richard Marti (:Paenglab)]

Yes.

Comment 9

[Jorg K (CEST = GMT+2)]

TB 65 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/f16d6de1d4024a7b7a07eeddea307eb6aaf9e9e3