Open Bug 1517309 Opened 5 years ago Updated 2 years ago

[meta] Fix WPT leaks

Categories

(Testing :: web-platform-tests, enhancement)

Product:
Testing
Component:
web-platform-tests
Version:
Version 3
Type:
enhancement

Tracking

(Not tracked)

People

(Reporter: mccr8, Assigned: mccr8)

References

(Depends on 4 open bugs)

Details

(Keywords: memory-leak, meta) 

A number of WPT tests leak, as indicated by the leak-threshold and lsan-allowed fields in the ini files. We should fix these leaks and remove the whitelists.
Depends on: 1517322
Component: General → web-platform-tests
James, when you were initially generating these whitelists, how did you account for intermittents? It seems like some of the leaks might not be present any more, but maybe I just need to retrigger the tests more.

I did this try run with the LSan whitelists hackily disabled:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=8316377451d2eb7a5fc768521eceaa5badcae1f9
Flags: needinfo?(james)
Depends on: 1517574
Depends on: 1517577
Depends on: 1517595
Mostly by doing multiple tryruns and keeping adding to the list until they passed reliably. So yes, there's a difficulty distinguishing between something that was fixed and something that's an infrequent intermittent.
Flags: needinfo?(james)
Depends on: 1517600
Depends on: 1517611
Depends on: 1517601
Depends on: 1518230
Depends on: 1518298
Depends on: 1518354
Depends on: 1519356
Depends on: 1516300
Depends on: 1519912
Depends on: 1519918
Depends on: 1520064
Depends on: 1520062
Depends on: 1520654
Depends on: 1519676
Depends on: 1479987
Depends on: 1486286
Depends on: 1521191
Depends on: 1508500
Depends on: 1523989
No longer depends on: 1479987
No longer depends on: 1486286
No longer depends on: 1516300
No longer depends on: 1518298
No longer depends on: 1519356
No longer depends on: 1519676
Depends on: 1524100
Depends on: 1526063
No longer depends on: 1524100
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.