1517329 - Add windowId propertie to webRequest details object

Status: RESOLVED INVALID

(WebExtensions :: Request Handling, enhancement)

Description

[kernp25]

So we can get information in what window the request is loading.

webNavigation also has windowId propertie in details object.

Comment 1

[kernp25]

What do you think about this?

Comment 2

[kernp25]

I know, that i can do:
function redirectAsync(requestDetails) {
  return new Promise(async (resolve, reject) => {
    let tabInfo = await browser.tabs.get(requestDetails.tabId);
    console.log(tabInfo.windowId);
  });
}

browser.webRequest.onBeforeRequest.addListener(
  redirectAsync,
  {urls: ["https://example.com/*"], types: ["main_frame"]},
  ["blocking"]
);

But this does not work for onResponseStarted or onCompleted event.

Comment 3

[Shane Caraveo (:mixedpuppy)]

Neither of those take a result from the listener and neither are blocking so you shouldn't try to behave like they are.  There is no reason that getting the windowId wouldn't work just like this:

browser.webRequest.onCompleted.addListener(async (details) => {
  let info = await browser.tabs.get(details.tabId);
  console.log(info);
}, ...);