Closed Bug 1517368 Opened 5 years ago Closed 5 years ago

"View in iTunes" button does not work on Nightly


(Core :: Networking: File, defect)

65 Branch
Not set



Tracking Status
firefox66 --- fixed


(Reporter: haik, Assigned: baku)




(3 files)

Some links that should result in the iTunes application being opened do not work on Nightly. I hit the bug on Mac Nightly 66 and did not test other platforms.

Expected result:

On the pages such as <>, clicking on the button "View in iTunes" should result in a prompt to open the iTunes application. If the user clicks through the prompt, the iTunes application should be opened.

Actual result:

Clicking on the "View in iTunes" button has no effect and the prompt is not displayed.

mozregression indicates the fix for bug 1459264 or bug 167475 introduced the problem:

  17:13.29 INFO: Last good revision: 2ee2f297c4106e017231ed67fba4034d766c942b
  17:13.29 INFO: First bad revision: c4bf214bd2e65e460fcd24a6483635c1d5cb4771
  17:13.29 INFO: Pushlog:
Blocks: 1459264
Flags: needinfo?(amarchesini)
This happens because creates an iframe and it sets its location to be: "itmss://"

I would suggest to relax the blocking of external protocol URLs in <iframe> allowing just the first one via PopupBlocker.
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Attachment #9034122 - Flags: review?(bugs)
Comment on attachment 9034122 [details] [diff] [review]

a test would be really nice
Attachment #9034122 - Flags: review?(bugs) → review+
Attachment #9034358 - Flags: review?(bugs)
Attached patch part 3 - testSplinter Review
Attachment #9034359 - Flags: review?(bugs)
Attachment #9034358 - Flags: review?(bugs) → review+
Attachment #9034359 - Flags: review?(bugs) → review+
Pushed by
Allow just the first external protocol URL in <iframe>, r=smaug
Expose PopupBlocker status via ChromeUtils, r=smaug
Expose PopupBlocker status via ChromeUtils - tests, r=smaug
You need to log in before you can comment on or make changes to this bug.