Build failure after bug 1501589 on OpenBSD

RESOLVED FIXED in Thunderbird 66.0

Status

defect
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: gaston, Assigned: gaston)

Tracking

Thunderbird 66.0
Unspecified
OpenBSD
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird65 fixed, thunderbird66 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

5 months ago
I had no issue building 64.0 betas on OpenBSD-current with clang 6.0, but building 65.0b1 fails on:

comm/ldap/xpcom/src/nsLDAPSecurityGlue.cpp:24:26: error: expected namespace name

which points to https://hg.mozilla.org/comm-central/rev/3eb79f25d25b.

Locally removing the 'using namespace net;' line fixes the build for me - i'm not sure why this line got added since it doesnt seem necessary, but if this passes try for tier1 platforms it would be nice to get it pushed to beta :)

sorry for not attaching a hg patch, i dont have a c-c clone around anymore :( ...
Attachment #9034118 - Flags: feedback?(jorgk)

Comment 1

5 months ago
Posted patch 1517418.patchSplinter Review
Thanks, they are both unneeded.
Attachment #9034118 - Attachment is obsolete: true
Attachment #9034118 - Flags: feedback?(jorgk)
Attachment #9034123 - Flags: review+

Updated

5 months ago
Assignee: nobody → landry

Comment 2

5 months ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d22bfa0e33eb
Remove unneeded 'using namespace ...' from nsLDAPSecurityGlue.cpp. r=jorgk
Status: NEW → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED

Updated

5 months ago
Target Milestone: --- → Thunderbird 66.0

Comment 3

5 months ago
Comment on attachment 9034123 [details] [diff] [review]
1517418.patch

I can uplift this if you care.
Attachment #9034123 - Flags: approval-comm-beta+
Assignee

Comment 4

5 months ago
Your call, i'll ship it locally anyway in my wip builds through https://cgit.rhaalovely.net/mozilla-thunderbird/commit/?h=beta&id=762becdbeac47dd71c01e505aeffee23c7238040 but i dunno if it can affect other packagers...
You need to log in before you can comment on or make changes to this bug.