1517434 - Use principal->GetIsSystemPrincipal() in xpc::CreateSandboxObject

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement, P3)

Description

[Jan de Mooij [:jandem]]

Boris suggested this in bug 1512029:

> Maybe file a followup to use principal->GetIsSystemPrincipal() here? Right now it's not very fast, but it could be made better....

We currently do:

  principal == nsXPConnect::SystemPrincipal()

(FWIW nsContentUtils::IsSystemPrincipal doesn't work here because nsContentUtils hasn't been initialized when we create the singleton scopes.)

Comment 1

[Bobby Holley (:bholley)]

We could add a convenience helper on BasePrincipal that does Kind() == eSystemPrincipal. That would be fastest and cleanest.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Yes, I have that implemented already.  Just waiting on try, because my first attempt discovered some places that had null nsIPrincipal* in non-obvious ways.  ;)

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1517434 part 1. Add a fast inline nsIPrincipal::IsSystemPrincipal. r=mccr8

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1517434 part 2. Convert existing callers of GetIsSystemPrincipal() to IsSystemPrincipal(). r=mccr8

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1517434 part 3. Get rid of pointer compares to nsXPConnect::SystemPrincipal. r=mccr8

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/417769fb3f0f
part 1.  Add a fast inline nsIPrincipal::IsSystemPrincipal.  r=mccr8
https://hg.mozilla.org/integration/autoland/rev/840ea11d3b3e
part 2.  Convert existing callers of GetIsSystemPrincipal() to IsSystemPrincipal().  r=mccr8
https://hg.mozilla.org/integration/autoland/rev/1853f95c94b1
part 3.  Get rid of pointer compares to nsXPConnect::SystemPrincipal.  r=mccr8

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/417769fb3f0f
https://hg.mozilla.org/mozilla-central/rev/840ea11d3b3e
https://hg.mozilla.org/mozilla-central/rev/1853f95c94b1